Closed
Bug 1448934
Opened 6 years ago
Closed 6 years ago
codespell: Add the */locales/en-US/ to the list of directories to be checked
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(4 files, 2 obsolete files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8962411 -
Attachment is obsolete: true
Attachment #8962411 -
Flags: review?(ahalberstadt)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8962410 [details] Bug 1448934 - Fix some spelling mistakes in locales/en-US https://reviewboard.mozilla.org/r/231266/#review236976 ::: browser/locales/en-US/chrome/overrides/netError.dtd:97 (Diff revision 3) > <!ENTITY netReset.longDesc "&sharedLongDesc;"> > > <!ENTITY netTimeout.title "The connection has timed out"> > <!ENTITY netTimeout.longDesc "&sharedLongDesc;"> > > -<!ENTITY unknownProtocolFound.title "The address wasn’t understood"> > +<!ENTITY unknownProtocolFound.title "The address wasn't understood"> This is definitely not good. Strings are supposed to use a proper apostrophe, and this change is also going to fail tests. See bug 1259859 ::: mobile/locales/en-US/overrides/netError.dtd:110 (Diff revision 3) > <!ENTITY netReset.longDesc2 "&sharedLongDesc3;"> > > <!ENTITY netTimeout.title "The connection has timed out"> > <!ENTITY netTimeout.longDesc2 "&sharedLongDesc3;"> > > -<!ENTITY unknownProtocolFound.title "The address wasn’t understood"> > +<!ENTITY unknownProtocolFound.title "The address wasn't understood"> Remove this string.
Attachment #8962410 -
Flags: review-
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8962410 [details] Bug 1448934 - Fix some spelling mistakes in locales/en-US https://reviewboard.mozilla.org/r/231266/#review236982 ::: toolkit/locales/en-US/chrome/global/keys.properties:7 (Diff revision 3) > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > # LOCALIZATION NOTE : FILE This file contains the application's labels for keys on the keyboard. > # If you decide to translate this file, you should translate it based on > -# the prevelant kind of keyboard for your target user. > +# the prevelent kind of keyboard for your target user. prevalent
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8962420 [details] Bug 1448934 - Add the trailing "/" for consistency https://reviewboard.mozilla.org/r/231274/#review237122
Attachment #8962420 -
Flags: review?(ahalberstadt) → review+
Updated•6 years ago
|
Attachment #8962410 -
Flags: review?(ahalberstadt)
Attachment #8962419 -
Flags: review?(ahalberstadt)
Comment 12•6 years ago
|
||
I'm not qualified/comfortable reviewing these changes. Please defer to :flod, :Pike or someone else on the l10n team.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 18•6 years ago
|
||
mozreview-review |
Comment on attachment 8962410 [details] Bug 1448934 - Fix some spelling mistakes in locales/en-US https://reviewboard.mozilla.org/r/231266/#review244908
Attachment #8962410 -
Flags: review?(francesco.lodolo) → review+
Comment 19•6 years ago
|
||
mozreview-review |
Comment on attachment 8970460 [details] Bug 1448934 - Remove a duplicate string https://reviewboard.mozilla.org/r/239230/#review244910 This doesn't look duplicate https://searchfox.org/mozilla-central/rev/8f06c1b9a080b84435a2906e420fe102e1ed780b/mobile/locales/en-US/overrides/netError.dtd#110 On a side note, compare-locales would trigger an error if there's a duplicate string.
Attachment #8970460 -
Flags: review?(francesco.lodolo) → review-
Comment 20•6 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #19) > Comment on attachment 8970460 [details] > Bug 1448934 - Remove a duplicate string > > https://reviewboard.mozilla.org/r/239230/#review244910 > > This doesn't look duplicate > https://searchfox.org/mozilla-central/rev/ > 8f06c1b9a080b84435a2906e420fe102e1ed780b/mobile/locales/en-US/overrides/ > netError.dtd#110 > > > On a side note, compare-locales would trigger an error if there's a > duplicate string. Not sure if comment 9 and comment 19 are related. In comment 9 I meant that the change should have been dropped from the patch, not the string from the file.
Comment 21•6 years ago
|
||
mozreview-review |
Comment on attachment 8970461 [details] Bug 1448934 - Add wasn to the ignore list until the upstream issue is fixed https://reviewboard.mozilla.org/r/239232/#review244916
Attachment #8970461 -
Flags: review?(francesco.lodolo) → review+
Comment 22•6 years ago
|
||
mozreview-review |
Comment on attachment 8962419 [details] Bug 1448934 - Add */locales/en-US/ to the checklist https://reviewboard.mozilla.org/r/231272/#review244918
Attachment #8962419 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Updated•6 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8970460 -
Attachment is obsolete: true
Comment 24•6 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcc3959e0019 Fix some spelling mistakes in locales/en-US r=flod https://hg.mozilla.org/integration/autoland/rev/c918f15f9071 Add */locales/en-US/ to the checklist r=flod https://hg.mozilla.org/integration/autoland/rev/bd36fbfb5f83 Add the trailing "/" for consistency r=ahal https://hg.mozilla.org/integration/autoland/rev/dfbc948fadaa Add wasn to the ignore list until the upstream issue is fixed r=flod
Comment 25•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fcc3959e0019 https://hg.mozilla.org/mozilla-central/rev/c918f15f9071 https://hg.mozilla.org/mozilla-central/rev/bd36fbfb5f83 https://hg.mozilla.org/mozilla-central/rev/dfbc948fadaa
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•