144896 - ipix plugin blanks out while trying to navigate

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[shrirang khanzode]

---moving over from bugscape....


mac only; works fine on windows, works on linux. Plugin not present on OS X...
seen on 0512 PR1 bits OS 9.2

 steps:

Go to the url
click on "take the ipix tour"

Observe that ipix plugin loads fine..however when you click inside it to 
navigate , the plugin are aturns blue. user is not able to navigate.



------- Additional Comment #1 From shrirang 2002-05-15 16:57 -------

well, in certain cases like hyundaiusa.com, where the plugin contents are not 
automatically moving, this might block them from using the plugin to navigate.

steps:
go to http://hyundaiusa.com
click on "sonata" form left (or pick any other model)
click on "interior"
click on "click here to see Virtual tour"

Observe that after plugin loads, when user tries to navigate, the screen blanks 
out. one can reset the plugin by right-clicking and selectiong 'reset 
viewpoint'...but this won't help in this case.



------- Additional Comment #2 From Peter Lubczynski 2002-05-15 17:08 -------

Can this be moved to Bugzilla?

Comment 1

[Peter Lubczynski]

Shrir,

Is this a regression? Does it repro in 6.2?

Comment 2

[shrirang khanzode]

regression..yes, this worked in 6.2.2

Comment 3

[Peter Lubczynski]

shoot!

Do you know if this is just OS 9.x or if Carbon or Win32 or Linux have this problem?

Thanks!

Comment 4

[shrirang khanzode]

This is just OS 9. OS  X does not have ipix plugin...I confirmed. Windows and 
linux works just fine.

http://www.ipix.com/download/alternative.html

Comment 5

[Peter Lubczynski]

Hm...okay....and what about full-page vs. embedded. Do you see any difference?

Comment 6

[scottputterman]

removing the adt1.0.0.  Let's get a fix and reviews and then nominate this.

Comment 7

[rubydoo123]

mass move PL RTM 

Comment 8

[Peter Lubczynski]

Attachment: ipix full-page testcase (.ips)

Comment 9

[Peter Lubczynski]

Attachment: full-page ipix testcase (.ipx) [was not broken]

Comment 10

[Peter Lubczynski]

You can get IPIX (for OS9) from:
http://www.ipix.com/cgi-bin/download.cgi

Comment 11

[selmer (gone)]

Is it yet possible to have an ETA on a fix?

Comment 12

[Peter Lubczynski]

cc:ing some more Mac heads as I'm kinda stuck. I have no idea why IPIX is
blanking out and painting itself grey on mouse down.

Here's what I see:

* Full-page IPIX works. See attachment 86136 [details]
* The browser sends a mouse down event to the plugin however it seems to be the
subsequent null event which causes the plugin to paint itself grey.

Comment 13

[Brian Nesse (gone)]

The IPIX download page only allows access to one file (a standalone IPIX viewer
[IpxSet32.exe]) which is to be totally useless on Mac OS 9.

Comment 14

[Brian Nesse (gone)]

"which is totally useless on Mac OS 9." --- I don't even see that there is a
plugin available.

Comment 15

[Brian Nesse (gone)]

Ok, I found it by using 4.x apparently they are filtering on the browser (badly I 
might add).

http://www.ipix.com/download/ppc_plugin.html

Comment 16

[Peter Lubczynski]

Turns out we were not calling SetWindow and returning early in
nsObjectFrame::DidReflow which was causing the problem. Looking back in CVS, it
looks like we completed this function in Netscape 6 which is why the bug does
not appear there. I am testing out the fix now and should have a patch posted
shortly.

Thanks to Tony who helped pull builds to narrow this down.

Comment 17

[Peter Lubczynski]

Comment on attachment 86136 [details]
full-page ipix testcase (.ipx) [was not broken]

To verify, use the testcase URL rather than this attachment.

Comment 18

[Peter Lubczynski]

Attachment: patch v.1

This 1-line patch removes the extra return in the middle of
nsObjectFrame::DidReflow and allows the method to complete on Mac. This fixes
IPIX. I ran though plugin tests with resizing the window, tabs, and loading in
the backaround and all was well. Please review.

Comment 19

[av (gone)]

Comment on attachment 87723 [details] [diff] [review]
patch v.1

r=av

Comment 20

[Patrick C. Beard]

Comment on attachment 87723 [details] [diff] [review]
patch v.1

sr=beard, I was wondering about that early return. Cut & paste error?

Comment 21

[av (gone)]

Early return is needed for some cases like windowless plugins. It was a
consideration that general case on Mac would be similar to windowless plugins on
Windows. I guess that is why it was there.

Comment 22

[Peter Lubczynski]

patch in trunk, marking FIXED.

Comment 23

[Jaime Rodriguez, Jr.]

shrir - can you verify this one on the trunk when you get a chance? thanks!

Comment 24

[shrirang khanzode]

Ipix is working great now on 0617 trunk on OS 9.2.2. verified !!

Comment 25

[shrirang khanzode]

are we not landing this on the brnch ? Else I can mark this 'verified'....

Comment 26

[shrirang khanzode]

marking verif, this is a bit confusing:)

Comment 27

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on adt's behalf) approval for checkin to the 1.0 branch, pending
drivers approval. pls check this is asap, then add the "fixed1.0.1" keyword.

Comment 28

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 87723 [details] [diff] [review]
patch v.1

Please land this on the 1.0.1 branch.  Once there, replace the
"mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.

Comment 29

[Peter Lubczynski]

fixed1.0.1, landed on the 1.0 branch

Comment 30

[shrirang khanzode]

hm, on 0722 branch , I see errors while loading ipix plugin (5.7) on OS 9.2. 
Worked well on the trunk, I remember. Reopen this ?

error seen " 

Comment 31

[shrirang khanzode]

error seen "could not open file 3bed-entrance_hire.ipx':-6 "  

Comment 32

[shrirang khanzode]

err...rr . Never mind, My machine eems to be the one which is having a problem. 
I tested on two other OS 9.2 boxes and things look great, ipix5.7  works on 
branch 0722. marking verified. will check what's wrong with my box...