144902 - Unclosed comment handling in strict mode needs to deal with "<!"

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Once bug 137628 gets fixed, there remains one issue in strict mode with comments
that don't end. After that bug we treat the comment start as text, and parse the
rest of the document normally, with one caveat: we are missing the "<!" part of
the comment open.

Comment 1

[gavin long]

*** Bug 153960 has been marked as a duplicate of this bug. ***

Comment 2

[gavin long]

Attachment: fun with comments (testcase)

A fairly pathological testcase with nested and unclosed SGML comments,
for your education and entertainment.

adapted from Adam Solesby's testcase (attachment 88988 [details] on the duplicate).

Comment 3

[harishd]

*** Bug 155722 has been marked as a duplicate of this bug. ***

Comment 4

[Ralf Hauser]

related bug in http://bugzilla.mozilla.org/show_bug.cgi?id=204362

Comment 5

[Christopher Hoess (gone)]

*** Bug 204362 has been marked as a duplicate of this bug. ***

Comment 6

[Craig Garner]

Not sure if this helps... simply having a "--" in a comment breaks it.
ex.

<! test -- will show up -->

displays

test -- will show up -->

<! test - will show up -->

displays

Comment 7

[Richard Brodie]

*** Bug 239185 has been marked as a duplicate of this bug. ***

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

The monster patch over in bug 88952 makes us not lose the <! at the beginning of
unclosed comments in standards mode.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

FIXED by checkin to bug 88952.

Comment 10

[Eric Fehrenbacher]

I am using 1.0.4 and am having problems with double dashes as well. My double
dashes are not inside a comment tag, but do break comment tags which appear
below it. I am rendering in transitional mode. Here is my <a
href="http://devel.micgi.com/~ericf/firefox/" target="_blank">testcase</a>.