1449062 - Avoid requesting thumbnails if a rich icon might be found

Status: NEW

(Firefox :: New Tab Page, enhancement, P3)

Description

[Ed Lee :Mardak]

While investigating the current state of bug 1401817, I noticed that when favicons and thumbnails are both missing, we end up requesting a thumbnail even though almost immediately we insert a rich icon from the remote tippy top list.

This is because we immediately fire off a screenshot request when processing the top sites.

Not sure if the fix should just directly ask FaviconFeed as that could slow down the fast path of getting top site data to content. But if the thumbnail request is delayed as given that it's async anyway, it could choose not to actually thumbnail.

Or alternatively, instead of initiating thumbnail requests when refreshing top sites, the thumbnail requests happen at some later time?

Comment 1

[Ed Lee :Mardak]

r1cky, can you grab this one? Although I'm not entirely sure what the approach should be. Maybe defer trying screenshots until FaviconFeed is ready? Although right now, nothing is directly accessing FaviconFeed and only via actions -- maybe it could continue to be indirect communication via the store / initialized state of favicons?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

I'll take a look

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4130