Closed Bug 1449064 Opened 7 years ago Closed 7 years ago

Use StaticPrefs in the HTML parser

Categories

(Core :: DOM: HTML Parser, enhancement, P2)

Product:
Core
Component:
DOM: HTML Parser
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(2 files)

Bug 1449064 - Convert html.* prefs to StaticPrefs.
59 bytes, text/x-review-board-request
hsivonen
: review+
Details
Bug 1449064 - Convert view_source.editor.external to a StaticPref.
59 bytes, text/x-review-board-request
hsivonen
: review+
Details
See bug 1448219 for details.
Comment on attachment 8962561 [details] Bug 1449064 - Convert html.* prefs to StaticPrefs. https://reviewboard.mozilla.org/r/231364/#review236970
Attachment #8962561 - Flags: review?(hsivonen) → review+
Comment on attachment 8962562 [details] Bug 1449064 - Convert view_source.editor.external to a StaticPref. https://reviewboard.mozilla.org/r/231366/#review236974
Attachment #8962562 - Flags: review?(hsivonen) → review+
Priority: -- → P2
Backed out changeset 614181fad27a (bug 1449064) for assertion failures on workspace/build/src/modules/libpref/Preferences.cpp Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/a8cb19565e34130e30c82b75ec132ebb44c013c9 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=614181fad27a9f6886a60f12cbe90a28c28e164f Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=170954638&repo=mozilla-inbound&lineNumber=1265 Log snippet: 19:49:21 INFO - TEST-START | accessible/tests/mochitest/tree/test_applicationacc.xul 19:49:21 INFO - TEST-SKIP | accessible/tests/mochitest/tree/test_applicationacc.xul | took 0ms 19:49:22 INFO - pk12util: PKCS12 IMPORT SUCCESSFUL 19:49:22 INFO - MochitestServer : launching [u'/Users/cltbld/tasks/task_1522288512/build/tests/bin/xpcshell', '-g', '/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/Resources', '-f', '/Users/cltbld/tasks/task_1522288512/build/tests/bin/components/httpd.js', '-e', "const _PROFILE_PATH = '/var/folders/mz/djtr5p_n6b5gp7cdl6_wr01m00000w/T/tmpU385uu.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/Users/cltbld/tasks/task_1522288512/build/tests/mochitest/server.js'] 19:49:22 INFO - runtests.py | Server pid: 760 19:49:22 INFO - runtests.py | Websocket server pid: 761 19:49:22 INFO - runtests.py | SSL tunnel pid: 762 19:49:22 INFO - Attempt to add a bool pref cache for preference 'content.notify.ontimer' at address '0x10d42e478'was made. However, a pref was already cached at this address. 19:49:22 INFO - Assertion failure: false (Should not have an existing pref cache for this address), at /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp:2888 19:49:22 INFO - #01: nsXPTCStubBase::Stub249()[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0x14c169] 19:49:22 INFO - #02: mozilla_dump_image[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0x14c984e] 19:49:22 INFO - #03: DumpCompleteHeap[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0xdff1d6] 19:49:22 INFO - #04: DumpBidiLine[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0x3aadb05] 19:49:22 INFO - #05: DumpBidiLine[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0x3aadfb5] 19:49:22 INFO - #06: NS_NewLocalFileWithCFURL[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0xd8d9a] 19:49:22 INFO - #07: NS_NewLocalFileWithCFURL[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0xd97b5] 19:49:22 INFO - #08: NS_NewLocalFileWithCFURL[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0xd54d4] 19:49:22 INFO - #09: NS_NewLocalFileWithCFURL[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0xdc39c] 19:49:22 INFO - #10: mozilla::VolatileBuffer::NonHeapSizeOfExcludingThis() const[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0x48fd5] 19:49:22 INFO - #11: nsXPTCStubBase::Stub249()[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0x1351bb] 19:49:22 INFO - #12: nsXPTCStubBase::Stub249()[/Users/cltbld/tasks/task_1522288512/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL +0xb80660] 19:49:22 INFO - #13: main[/Users/cltbld/tasks/task_1522288512/build/tests/bin/xpcshell +0x1df7] 19:52:32 ERROR - TEST-UNEXPECTED-FAIL | runtests.py | Timed out while waiting for server startup.
Flags: needinfo?(n.nethercote)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5d5e59074b0be7adb4f5e6cebf9c2e414adf93 Bug 1449064 (attempt 2) - Convert view_source.editor.external to a StaticPref. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/11481779133c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Flags: needinfo?(n.nethercote)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: