Closed Bug 1449071 Opened 6 years ago Closed 4 years ago

Intermittent toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | Test timed out -

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla74

People

(Reporter: intermittent-bug-filer, Assigned: emk)

References

Details

(Keywords: intermittent-failure, Whiteboard: [retriggered])

Attachments

(2 files, 3 obsolete files)

Since 26th March, 2 days ago there already are 38 failures.
:ddurst could you please take a look?
Flags: needinfo?(ddurst)
:kmag  We have found that this changeset https://hg.mozilla.org/integration/mozilla-inbound/rev/d854ebbcbb7e39b29508c856b118ca52f6623d53   that you have landed in this push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6b6162e512477c86e920dd24b27522526c23cf6b&filter-searchStr=Linux%20x64%20opt%20opt-mochitest-browser-chrome-e10s  caused Intermittent toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js failures.
We have re triggered 20 times and failed 2 times on the mentioned push. It did not fail on the other pushes in which we have re triggered this test.
Could you please take a look and fix this?
Blocks: 1446686
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][retriggered]
In the last 7 days we have 81 failures.
They occur on Linux (opt), Linux x64 (pgo, opt, asan), linux64-qr (debug), OS X 10.10 (opt), Windows 7 (opt, pgo, debug), windows10-64 (opt), windows7-32-nightly (opt).
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=172351507&lineNumber=9507
Attached patch Skip on Linux and Win 7 (obsolete) — Splinter Review
Due to the failure rate of this bug I've made a patch for disabling on Linux and Windows 7. Joel could you please take a look and see if it's ok? Thank you.
Attachment #8966071 - Flags: review?(jmaher)
Comment on attachment 8966071 [details] [diff] [review]
Skip on Linux and Win 7

Review of attachment 8966071 [details] [diff] [review]:
-----------------------------------------------------------------

really close!

::: toolkit/mozapps/extensions/test/browser/browser.ini
@@ +63,4 @@
>  [browser_dragdrop_incompat.js]
>  [browser_experiments.js]
>  [browser_file_xpi_no_process_switch.js]
> +skip-if = os == 'linux' || (os == 'win' && os_version = '6.1') # Bug 1449071 - disable on Linux and Windows 7 due to frequent failures

we need !debug as well for both linux and win7.  Also can we do linux64 only and keep this on linux32?
Attachment #8966071 - Flags: review?(jmaher) → review-
Attached patch Skip on Linux64 and Win 7 (obsolete) — Splinter Review
Made the modifications you mentioned. Thanks.
Attachment #8966071 - Attachment is obsolete: true
Attachment #8966074 - Flags: review?(jmaher)
Attached patch Skip on Linux64 and Win 7 (obsolete) — Splinter Review
Noticed a syntax mistake and corrected it.
Attachment #8966074 - Attachment is obsolete: true
Attachment #8966074 - Flags: review?(jmaher)
Attachment #8966075 - Flags: review?(jmaher)
Comment on attachment 8966075 [details] [diff] [review]
Skip on Linux64 and Win 7

Review of attachment 8966075 [details] [diff] [review]:
-----------------------------------------------------------------

one small error

::: toolkit/mozapps/extensions/test/browser/browser.ini
@@ +67,1 @@
>  [browser_getmorethemes.js]

os_version needs an ==
Attachment #8966075 - Flags: review?(jmaher) → review-
That was why I edited the patch earlier. I did not run qref and it was not updated. Thought I would solve this without bugging you too much. Thanks
Attachment #8966075 - Attachment is obsolete: true
Attachment #8966089 - Flags: review?(jmaher)
Comment on attachment 8966089 [details] [diff] [review]
Skip on Linux64 and Win 7

Review of attachment 8966089 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8966089 - Flags: review?(jmaher) → review+
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82693b15029f
Disable toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js on Linux64 and Win7 due to frequent failures. r=jmaher
Keywords: checkin-needed
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]
In the last 7 days, there are 77 failures.
They occur on:
linux32 - opt
linux64 - pgo, asan, opt
linux32-nightly - opt
OS X 10.10 - opt, debug
windows10-64 - pgo
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=174950356&lineNumber=6005
[task 2018-04-21T16:26:39.186Z] 16:26:39     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | Test timed out - 
[task 2018-04-21T16:26:39.186Z] 16:26:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-21T16:26:39.188Z] 16:26:39     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | Should not have seen an install of file:///builds/worker/workspace/build/tests/mochitest/browser/toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop1.xpi in state 3 - 
[task 2018-04-21T16:26:39.188Z] 16:26:39     INFO - Stack trace:
[task 2018-04-21T16:26:39.189Z] 16:26:39     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:null:166
[task 2018-04-21T16:26:39.189Z] 16:26:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-21T16:26:39.190Z] 16:26:39     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | Should not have seen an install of file:///builds/worker/workspace/build/tests/mochitest/browser/toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop2.xpi in state 3 - 
[task 2018-04-21T16:26:39.190Z] 16:26:39     INFO - Stack trace:
[task 2018-04-21T16:26:39.192Z] 16:26:39     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:null:166
[task 2018-04-21T16:26:39.192Z] 16:26:39     INFO - GECKO(7209) | MEMORY STAT | vsize 2648MB | residentFast 318MB | heapAllocated 85MB
[task 2018-04-21T16:26:39.194Z] 16:26:39     INFO - TEST-OK | toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | took 45055ms
[task 2018-04-21T16:26:39.194Z] 16:26:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-21T16:26:39.195Z] 16:26:39     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | Found a tab after previous test timed out: about:blank - 
[task 2018-04-21T16:26:39.195Z] 16:26:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-21T16:26:39.196Z] 16:26:39     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_file_xpi_no_process_switch.js | Found a tab after previous test timed out: about:robots - 
[task 2018-04-21T16:26:39.197Z] 16:26:39     INFO - checking window state
ddurst, I see this was disabled but still occuring. Could you please have a look at this?
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb9ba78368a6d27a76c66054a39882c490052373
Bug 1449071: Disable browser_file_xpi_no_process_switch for too frequent failures. r=me,test-only DONTBUILD
Flags: needinfo?(kmaglione+bmo)

Sometimes newTab will get install notification first. But popup will not be
shown until newTab becmoes active in that case. I could not find a good event
to catch this, so I had to resort to setTimeout.

Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: needinfo?(thedurst)
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/7b985af0a4d6
Unbitrot and fix intermittent timeout of browser_file_xpi_no_process_switch.js. r=mossop

Forgot to remove leave-open.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [retriggered][stockwell disabled] → [retriggered]
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.