Closed
Bug 1449084
Opened 7 years ago
Closed 7 years ago
Don't add a marker in profiler_add_marker_for_thread if the profiler is inactive
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962586 [details]
Bug 1449084 - Early-exit in profiler_add_marker_for_thread if the profiler is not running.
https://reviewboard.mozilla.org/r/231398/#review238904
LGTM
It might be nice in the future if we could have some way to check if the profiler is running for early returns without having to acquire the lock (e.g. with an atomic?)
Attachment #8962586 -
Flags: review?(nika) → review+
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/dc5e006ffdad
Early-exit in profiler_add_marker_for_thread if the profiler is not running. r=mystor
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•