Closed Bug 1449084 Opened 2 years ago Closed 2 years ago

Don't add a marker in profiler_add_marker_for_thread if the profiler is inactive

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8962586 [details]
Bug 1449084 - Early-exit in profiler_add_marker_for_thread if the profiler is not running.

https://reviewboard.mozilla.org/r/231398/#review238904

LGTM

It might be nice in the future if we could have some way to check if the profiler is running for early returns without having to acquire the lock (e.g. with an atomic?)
Attachment #8962586 - Flags: review?(nika) → review+
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/dc5e006ffdad
Early-exit in profiler_add_marker_for_thread if the profiler is not running. r=mystor
https://hg.mozilla.org/mozilla-central/rev/dc5e006ffdad
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.