Closed
Bug 1449097
Opened 7 years ago
Closed 7 years ago
Expose function from Servo side to replace GetStatesForPseudoClass in InspectorUtils
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8962623 [details]
Bug 1449097 - Use Servo to implement GetStatesForPseudoClass function in InspectorUtils.
https://reviewboard.mozilla.org/r/231480/#review237036
::: servo/ports/geckolib/glue.rs:5125
(Diff revision 1)
> +pub unsafe extern "C" fn Servo_PseudoClass_GetStates(name: *const nsACString) -> u64 {
> + let name = name.as_ref().unwrap().as_str_unchecked();
> + match NonTSPseudoClass::parse_non_functional(name) {
> + None => 0,
> + // Ignore :any-link since it contains both visited and unvisited state.
> + Some(NonTSPseudoClass::AnyLink) => 0,
nit: Maybe merge the branches?
```
None |
Some(NonTSPseudoClass::AnyLink) => 0,
```
(Not sure it's necessarily better, your call).
Attachment #8962623 -
Flags: review?(emilio) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8962623 [details]
Bug 1449097 - Use Servo to implement GetStatesForPseudoClass function in InspectorUtils.
https://reviewboard.mozilla.org/r/231480/#review237036
> nit: Maybe merge the branches?
>
> ```
> None |
> Some(NonTSPseudoClass::AnyLink) => 0,
> ```
>
> (Not sure it's necessarily better, your call).
I'd just keep it as-is. Don't really think it matters much.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44ffa321cfdf
Use Servo to implement GetStatesForPseudoClass function in InspectorUtils. r=emilio
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•