Expose function from Servo side to replace GetStatesForPseudoClass in InspectorUtils

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

No description provided.

Comment 2

a year ago
mozreview-review
Comment on attachment 8962623 [details]
Bug 1449097 - Use Servo to implement GetStatesForPseudoClass function in InspectorUtils.

https://reviewboard.mozilla.org/r/231480/#review237036

::: servo/ports/geckolib/glue.rs:5125
(Diff revision 1)
> +pub unsafe extern "C" fn Servo_PseudoClass_GetStates(name: *const nsACString) -> u64 {
> +    let name = name.as_ref().unwrap().as_str_unchecked();
> +    match NonTSPseudoClass::parse_non_functional(name) {
> +        None => 0,
> +        // Ignore :any-link since it contains both visited and unvisited state.
> +        Some(NonTSPseudoClass::AnyLink) => 0,

nit: Maybe merge the branches?

```
    None |
    Some(NonTSPseudoClass::AnyLink) => 0,
```

(Not sure it's necessarily better, your call).
Attachment #8962623 - Flags: review?(emilio) → review+
Assignee

Comment 3

a year ago
mozreview-review-reply
Comment on attachment 8962623 [details]
Bug 1449097 - Use Servo to implement GetStatesForPseudoClass function in InspectorUtils.

https://reviewboard.mozilla.org/r/231480/#review237036

> nit: Maybe merge the branches?
> 
> ```
>     None |
>     Some(NonTSPseudoClass::AnyLink) => 0,
> ```
> 
> (Not sure it's necessarily better, your call).

I'd just keep it as-is. Don't really think it matters much.

Comment 4

a year ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44ffa321cfdf
Use Servo to implement GetStatesForPseudoClass function in InspectorUtils. r=emilio

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44ffa321cfdf
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.