1449165 - Devtools Reps: update bundle to v0.22.0

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1449165 - devtools-reps: release v0.22.0; .

Review commit: https://reviewboard.mozilla.org/r/233722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233722/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8964980 [details]
Bug 1449165 - devtools-reps: release v0.22.0; .

https://reviewboard.mozilla.org/r/233722/#review240048

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba6887e3e863
devtools-reps: release v0.22.0; r=Honza.

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing devtools at devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ba6887e3e863751868e6309fc41a0848d7bd14a1

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=172321552&repo=autoland&lineNumber=2562

Backout: https://hg.mozilla.org/integration/autoland/rev/ed92025bc4f9e1c5609fe308e11c83353f6bf177

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Taking a look at the failure now

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1449165 - Fix test failure in browser_inspector_extension_sidebar with new reps bundle; .

For some reason, the test was failing. I suspect that it would
take some time for the object to expand, giving some time for the
targeted node (the root, containing the body node in an object), to
be turned into TINY mode, and thus making it impossible for the
onMouseOut listener to be executed.
This patch waits for the object inspector to be expanded so we make
sure to only target the body node.

Review commit: https://reviewboard.mozilla.org/r/234868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234868/

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8964980 [details]
Bug 1449165 - devtools-reps: release v0.22.0; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233722/diff/1-2/

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

TRY looks good https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb88c3d416d288d8fdd9bc7d9fc51a5fd456b032

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

By the way, locally I run the failing test with --verify twice without any failure

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8966139 [details]
Bug 1449165 - Fix test failure in browser_inspector_extension_sidebar with new reps bundle; .

https://reviewboard.mozilla.org/r/234868/#review241316

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c8e9118872c
devtools-reps: release v0.22.0; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/86ae6ed07c1a
Fix test failure in browser_inspector_extension_sidebar with new reps bundle; r=rpl.

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8c8e9118872c
https://hg.mozilla.org/mozilla-central/rev/86ae6ed07c1a