Closed Bug 1449244 Opened 2 years ago Closed 2 years ago

Remove SphinxBase

Categories

(Core :: Web Speech, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: tjr, Assigned: tjr)

Details

Attachments

(1 file)

As far as I can tell, no one is using this library. The person who checked it in (Kelly Davis) is okay with removing it.
Attachment #8962783 - Flags: review?(drno)
Attachment #8962783 - Flags: review?(cpearce)
Attachment #8962783 - Flags: review?(drno)
Discussed this on irc, andrenatal is okay with removing it. In the future we might bring it back
Comment on attachment 8962783 [details]
Bug 1449244 Remove SphinxBase

https://reviewboard.mozilla.org/r/231630/#review237232

LGTM in general.

I'm only wondering if the remaining code in dom/media/webspeech/recognition is dead now as well?
Attachment #8962783 - Flags: review?(drno) → review+
Andre what should we do with the code in dom/media/webspeech/recognition ?
Flags: needinfo?(anatal)
That code we should keep. We removed only the service for pocketsphinx, but we need that code to use to build services for other backends.
Flags: needinfo?(anatal)
https://hg.mozilla.org/mozilla-central/rev/55370a40de63
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.