Closed
Bug 1449244
Opened 7 years ago
Closed 7 years ago
Remove SphinxBase
Categories
(Core :: Web Speech, enhancement)
Core
Web Speech
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
Details
Attachments
(1 file)
As far as I can tell, no one is using this library. The person who checked it in (Kelly Davis) is okay with removing it.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8962783 -
Flags: review?(drno)
Attachment #8962783 -
Flags: review?(cpearce)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8962783 -
Flags: review?(drno)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Discussed this on irc, andrenatal is okay with removing it. In the future we might bring it back
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962783 [details]
Bug 1449244 Remove SphinxBase
https://reviewboard.mozilla.org/r/231630/#review237232
LGTM in general.
I'm only wondering if the remaining code in dom/media/webspeech/recognition is dead now as well?
Attachment #8962783 -
Flags: review?(drno) → review+
|
|
||
Comment 4•7 years ago
|
||
Andre what should we do with the code in dom/media/webspeech/recognition ?
Flags: needinfo?(anatal)
|
||
Comment 5•7 years ago
|
||
That code we should keep. We removed only the service for pocketsphinx, but we need that code to use to build services for other backends.
Flags: needinfo?(anatal)
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55370a40de63
Remove SphinxBase r=drno
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•