Closed
Bug 1449254
Opened 6 years ago
Closed 6 years ago
Dodgy build define in JS stack dump function
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(1 file)
From the looks of it, the idea was to null-terminate the string before printing it/handing it to the debugger on Windows.
|
Assignee | |
Comment 1•6 years ago
|
||
Or actually no, we always null-terminated everywhere, it's just that for the code path not intended for Windows, the handling of that was moved into the VsprintfLiteral helper. Given that in practice we've been using vsnprintf even on Windows and nobody complained, I wonder whether to fix the build define or just remove the Windows-specific code path?
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962852 [details] Bug 1449254 - Use vsnprintf for formatting DebugDump() output on Windows, too. https://reviewboard.mozilla.org/r/231650/#review237346
Attachment #8962852 -
Flags: review?(mrbkap) → review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/e16e68c35e9a Use vsnprintf for formatting DebugDump() output on Windows, too. r=mrbkap
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e16e68c35e9a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•