1449287 - Renew telemetry histograms

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Got this expiry email:

===
The following histograms will be expiring on 2018-05-07, and should be removed from the codebase, or have their expiry versions updated:

* CHECKERBOARD_DURATION expires in version 62.0a1 (watched by [e-mail]) - Duration of a checkerboard event in milliseconds
* CHECKERBOARD_PEAK expires in version 62.0a1 (watched by [e-mail]) - Peak number of CSS pixels checkerboarded during a checkerboard event (the high value is the size of a 4k display with max APZ zooming)
* CHECKERBOARD_POTENTIAL_DURATION expires in version 62.0a1 (watched by [e-mail]) - Duration of a chunk of time (in ms) that could reasonably have had checkerboarding
* CHECKERBOARD_SEVERITY expires in version 62.0a1 (watched by [e-mail]) - Opaque measure of the severity of a checkerboard event
* COMPOSITOR_ANIMATION_DURATION expires in version 62.0a1 (watched by [e-mail]) - Duration of animations running on the compositor in milliseconds
* COMPOSITOR_ANIMATION_MAX_CONTIGUOUS_DROPS_APZ expires in version 62.0a1 (watched by [e-mail]) - For APZ/scrolling compositor animations, the maximum number of contiguous frame drops encountered
* COMPOSITOR_ANIMATION_MAX_CONTIGUOUS_DROPS_CHROME expires in version 62.0a1 (watched by [e-mail]) - For compositor animations of chrome-process layers, the maximum number of contiguous frame drops encountered
* COMPOSITOR_ANIMATION_MAX_CONTIGUOUS_DROPS_CONTENT expires in version 62.0a1 (watched by [e-mail]) - For compositor animations of content-process layers, the maximum number of contiguous frame drops encountered
* COMPOSITOR_ANIMATION_MAX_LAYER_AREA expires in version 62.0a1 (watched by [e-mail]) - High-watermark of layer area affected during a compositor animation. Units are layer pixels squared.
* COMPOSITOR_ANIMATION_THROUGHPUT_APZ expires in version 62.0a1 (watched by [e-mail]) - Frame throughput ratio (scaled up to 1000) for APZ/scrolling animations in the compositor.
* COMPOSITOR_ANIMATION_THROUGHPUT_CHROME expires in version 62.0a1 (watched by [e-mail]) - Frame throughput ratio (scaled up to 1000) for compositor animations of chrome-process layers.
* COMPOSITOR_ANIMATION_THROUGHPUT_CONTENT expires in version 62.0a1 (watched by [e-mail]) - Frame throughput ratio (scaled up to 1000) for compositor animations of content-process layers.
* CONTENT_RESPONSE_DURATION expires in version 62.0a1 (watched by [e-mail]) - Main thread response times for APZ notifications about input events (ms)
===


I'm not sure which of these we want to keep and which we want to let lapse.

Probably want to keep the checkerboarding ones for the eventual comparison against webrender. The COMPOSITOR_ANIMATION ones seems to be specific to the AsyncCompositionManager codepath so they wouldn't really be comparable to the WR numbers if we managed to instrument that. CONTENT_RESPONSE_DURATION can probably be dropped now?

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Harald, any thoughts on the COMPOSITOR_ANIMATION telemetry probes? IIRC you were one of the parties who requested these, do you know if these probes are still being monitored?

Comment 2

[:Harald Kirschner :digitarald]

Kats, we had some high hopes for those probes but have not used them since – probably also because they are hard to analyze with their unique distributions.

If we don't have graphics features shipping as experiments in the future (apart from webrender, which would need new metrics) I don't see why we would need to keep them around.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Thanks for the info!

I'll remove those probes and renew the rest. I realized CONTENT_RESPONSE_DURATION would be good to keep around because with webrender there's going to be some thread-bouncing of the messages that trigger CONTENT_RESPONSE_DURATION and it would be good to have this probe to see if it increases latency.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca13d18a1d579b79162bf78f6517c7b485ca4144

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1449287 - Remove obsolete compositor animation telemetry probes.

Review commit: https://reviewboard.mozilla.org/r/234196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234196/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1449287 - Extend useful APZ telemetry probes for a few more versions.

Review commit: https://reviewboard.mozilla.org/r/234198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234198/

Comment 7

[François Marier [:francois]]

Comment on attachment 8965454 [details]
Bug 1449287 - Extend useful APZ telemetry probes for a few more versions.

https://reviewboard.mozilla.org/r/234198/#review239836

Comment 8

[Botond Ballo [:botond] [away until Jun 24]]

Comment on attachment 8965453 [details]
Bug 1449287 - Remove obsolete compositor animation telemetry probes.

https://reviewboard.mozilla.org/r/234196/#review240260

It's a bit unfortunate that we put effort into developing these probes and then never used them :/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f734b7b3c44
Remove obsolete compositor animation telemetry probes. r=botond
https://hg.mozilla.org/integration/autoland/rev/5d49be8bf0a7
Extend useful APZ telemetry probes for a few more versions. r=francois

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4f734b7b3c44
https://hg.mozilla.org/mozilla-central/rev/5d49be8bf0a7