1449294 - Capture thumbnails with tracking protection always enabled

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Comment 1

[Ed Lee :Mardak]

Forgot to comment ;)

There's concerns of the thumbnail service potentially leaking data leading to bugs like bug 1435432.

There's also issues of thumbnails taking a while to show up.

Turning on tracking protection should speed up thumbnails by reducing the number of connections needed!

Comment 2

[Ed Lee :Mardak]

Attachment: before / after

These 4 pages do have content removed with tracking protection. It's most noticeable in the 2nd thumbnail where the top empty whitespace is gone and one of the page's image shows a broken image indicator.

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1449294 - Capture thumbnails with tracking protection always enabled.

Review commit: https://reviewboard.mozilla.org/r/231666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231666/

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 8962841 [details]
Bug 1449294 - Capture thumbnails with tracking protection always enabled.

https://reviewboard.mozilla.org/r/231666/#review237688

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1504ecb0dc31
Capture thumbnails with tracking protection always enabled. r=adw

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1504ecb0dc31

Comment 7

[François Marier [:francois]]

Comment on attachment 8962841 [details]
Bug 1449294 - Capture thumbnails with tracking protection always enabled.

https://reviewboard.mozilla.org/r/231666/#review241550

::: toolkit/components/thumbnails/content/backgroundPageThumbsContent.js:43
(Diff revision 1)
>        priority = Ci.nsISupportsPriority.PRIORITY_LOWEST;
>  
>      docShell.allowMedia = false;
>      docShell.allowPlugins = false;
>      docShell.allowContentRetargeting = false;
>      let defaultFlags = Ci.nsIRequest.LOAD_ANONYMOUS |

You should also add `nsIChannel::LOAD_CLASSIFY_URI` to that list so that Activity Stream thumbnails are automatically run through Safe Browsing.

This will avoid taking screenshots of phishing or malware sites.