Closed Bug 1449350 Opened 6 years ago Closed 6 years ago

distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('six')

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(2 files, 1 obsolete file)

[gecko] Move six to first in websocketprocessbridge_requirements.txt
707 bytes, patch
nthomas
: review+
Details | Diff | Splinter Review
[gecko] Add six to initial virtualenv setup
898 bytes, patch
mozilla
: review+
Details | Diff | Splinter Review 
Particularly on esr52, in the first fifteen minutes of the hour. eg: https://treeherder.mozilla.org/logviewer.html#?job_id=170619437&repo=mozilla-esr52&lineNumber=2093
Comment on attachment 8962908 [details] [diff] [review]
[gecko] Move six earlier in websocketprocessbridge_requirements.txt

We could even move this to the top, above twisted; six doesn't require twisted, but an unpinned twisted dep may require six at some point.
Attachment #8962908 - Flags: review?(aki) → review+
Updated patch, carrying r+
Attachment #8962908 - Attachment is obsolete: true
Attachment #8962910 - Flags: review+
Pushed by nthomas@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b09e7b25bcbe
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('six'), r=aki
The backstory here is
* we saw a lot of red windows tests jobs on https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr52&revision=57bd35fa86186b240d889fa8d8fad97033d4ddbf
* these all run on older hardware, t-w732, with python not able to talk TLSv1.2
* if we use pip to install a package containing a setup.py which specifies requirements, then setuptools doesn't respect the args we've given to pip to install from our pypi servers, so it talks to pypi.python.org
* pypi.python.org is migrating to a new CDN provider, and having brownouts on TLSv1.0 and v1.1 for the first 15 minutes of the hour

So jobs fail when the starts align. The (attempted) fix is get pip to grab six before txWS needs it, so we setuptools doesn't need to reach out for anything. I presume we don't have test failures on newer branches because they can still talk to external pypi, but they shouldn't be doing so.
We're still hitting errors with attachment 8962910 [details] [diff] [review], eg https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr52&filter-searchStr=windows&filter-tier=1&selectedJob=170695247.

Here's your suggestion to install six immediately after setting up the virtualenv.
Attachment #8962970 - Flags: review?(aki)
Attachment #8962970 - Flags: review?(aki) → review+
Comment on attachment 8962970 [details] [diff] [review]
[gecko] Add six to initial virtualenv setup

Backout earlier patch:
https://hg.mozilla.org/releases/mozilla-esr52/rev/ebb75ac4798c5e17be6233ad82d2ad8e64ed4585

Land this one with version pinned:
https://hg.mozilla.org/releases/mozilla-esr52/rev/1d384e482912ef42efadfd09bfb87de6755a66fa

Will follow up on inbound/beta once we have some data about effectiveness.
https://hg.mozilla.org/mozilla-central/rev/b09e7b25bcbe
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Note to self - come back here and figure out what we want to do with syncing branches.
Flags: needinfo?(nthomas)
Component: General Automation → General
See Also: → 1459391
Blocks: 1460684
(In reply to Nick Thomas [:nthomas] (UTC+12) from comment #8)
> Backout earlier patch:
> https://hg.mozilla.org/releases/mozilla-esr52/rev/
> ebb75ac4798c5e17be6233ad82d2ad8e64ed4585

Relanded as https://hg.mozilla.org/releases/mozilla-esr52/rev/187838f9aadb406508259dc934cd99f66da7ce6b because something broke between dc927ef3e774 on May 26 and restoring buidlbot jobs today (bug 1465288). Possibly 1463592.
I think we're done here.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Flags: needinfo?(nthomas)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: