Open Bug 1449374 Opened 6 years ago Updated 2 years ago

Intermittent /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - assert_unreached: onerror should not fire. Reached unreachable code

Categories

(Core :: DOM: Security, defect, P5)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [domsecurity-intermittent][retriggered][stockwell disabled])

Attachments

(2 files)

Disable on Win7 pgo
986 bytes, patch
NarcisB
: review+
Details | Diff | Splinter Review
Disable on Win10
932 bytes, patch
gbrown
: review+
Details | Diff | Splinter Review
Whiteboard: [domsecurity-intermittent]
Over the last 7 days there are 31 failures on this bug. This happens once on windows7-32-nightly and more frequently on windows7-32.
Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?job_id=178898372&repo=mozilla-inbound&lineNumber=1635

01:33:38     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports prefetch. 
01:33:38     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports performance APIs. 
01:33:38     INFO - TEST-UNEXPECTED-FAIL | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - assert_unreached: onerror should not fire. Reached unreachable code
01:33:38     INFO - EventHandlerNonNull*assert_link_prefetches@http://web-platform.test:8000/content-security-policy/support/prefetch-helper.js:33:18
01:33:38     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:22:9
01:33:38     INFO - EventListener.handleEvent*@http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:12:7
01:33:38     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1490:20
01:33:38     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:517:13
Flags: needinfo?(ckerschb)
:vino, can you take a look at this one please?
Flags: needinfo?(ckerschb) → needinfo?(cegvinoth)
Whiteboard: [domsecurity-intermittent] → [stockwell needswork][domsecurity-intermittent]
If we look at this bug in the last 30 days this bug has a low failure rate until this range of pushes 
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=opt-web-platform-tests-e10s-8&tochange=e6013642ac9da06a5a8a615122c0168b2355783e&filter-resultStatus=success&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&fromchange=f288a2c9c4390898a17ad9f964218b52b87d8028&selectedJob=179261390

where we can see a major increase in failure rate beginning with this push http://tinyurl.com/ybam9ntr. 
Matt can you please take a look at this see if you can find the connection between your push and this failure? Thank you.
Flags: needinfo?(matt.woodrow)
The patch there just changed timings of when we paint. This test doesn't look like it's testing painting at all, so the changed timings might just be making an unrelated intermittent more frequent.
Flags: needinfo?(matt.woodrow)

        Attachment #8979433 -
        Flags: review?(nbeleuzu)

        Attachment #8979433 -
        Flags: review?(nbeleuzu) → review+

    
    

    
  
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b47348c5f123
Disable /content-security-policy/prefetch-src/prefetch-allowed.html on Win7 !debug for frequent failures. r=nbeleuzu
Keywords: leave-open
Whiteboard: [domsecurity-intermittent][retriggered][stockwell disable-recommended] → [domsecurity-intermittent][retriggered][stockwell disabled]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
This bug has failed 42 times in the last 7 days. Failures happen on windows64 platform on pgo and opt build types.

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=195156322&repo=mozilla-inbound&lineNumber=1313

TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports performance APIs. 
21:13:31     INFO - TEST-UNEXPECTED-FAIL | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - assert_unreached: onerror should not fire. Reached unreachable code
21:13:31     INFO - EventHandlerNonNull*assert_link_prefetches@http://web-platform.test:8000/content-security-policy/support/prefetch-helper.js:33:18
21:13:31     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:22:9
21:13:31     INFO - EventListener.handleEvent*@http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:12:7
21:13:31     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20
21:13:31     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:561:13
21:13:31     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:9:5
21:13:31     INFO - TEST-OK | /content-security-policy/prefetch-src/prefetch-allowed.html | took 309ms
21:13:31     INFO - PID 6192 | 1534886011128	Marionette	INFO	Stopped listening on port 2828
21:13:31     INFO - PID 6192 | [Parent 6192, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | JavaScript error: resource://onboarding/onboarding.js, line 29: NS_ERROR_NOT_AVAILABLE:
21:13:31     INFO - PID 6192 | [Parent 6192, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | [Child 9204, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | [Child 9204, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | [Parent 6192, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | [Child 8528, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | [Child 8528, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
21:13:31     INFO - PID 6192 | [Parent 6192, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 188
21:13:31     INFO - PID 6192 | JavaScript error: resource:///modules/AsyncTabSwitcher.jsm, line 256: TypeError: browser.frameLoader is null

jmaher: I NI you on this bug because I was unable to do so for the triage owner.
Flags: needinfo?(jmaher)
Whiteboard: [domsecurity-intermittent][retriggered][stockwell disabled] → [stockwell needswork] [domsecurity-intermittent][retriggered][stockwell disabled]

    
    

    
  
Wennie- As Cristoph is out for the next 2 weeks, I would like to ensure someone has a chance to look at this.  At the current failure rate I image we would disable this in another 2 weeks which would mean nobody on the dom:security team would have a chance to fix the issue.  As a note, this is disabled on win7 pgo/opt- the new failure is for win10 pgo/opt.
Flags: needinfo?(jmaher) → needinfo?(wleung)

    
    

    
  
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #37)
> Wennie- As Cristoph is out for the next 2 weeks, I would like to ensure
> someone has a chance to look at this.  At the current failure rate I image
> we would disable this in another 2 weeks which would mean nobody on the
> dom:security team would have a chance to fix the issue.  As a note, this is
> disabled on win7 pgo/opt- the new failure is for win10 pgo/opt.

I am working on other bugs, but I can take a look at this bug alongside.
Will update on this after looking into it.
Flags: needinfo?(cegvinoth)

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Update:
There have been 50 failures in the last week.
Almost all the failures occur on windows10-64 / pgo & opt.
There are also 4 occurrences for: windows10-64-msvc, windows10-64-nightly, windows2012-64, all of them on the opt build.

Recent relevat log file: https://treeherder.mozilla.org/logviewer.html#?job_id=197189570&repo=mozilla-inbound&lineNumber=1317

11:25:26     INFO - TEST-START | /content-security-policy/prefetch-src/prefetch-allowed.html
11:25:26     INFO - Setting pref security.mixed_content.upgrade_display_content (false)
11:25:26     INFO - Setting pref security.csp.enable_violation_events (true)
11:25:26     INFO - 
11:25:26     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports prefetch. 
11:25:26     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports performance APIs. 
11:25:26     INFO - TEST-UNEXPECTED-FAIL | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - assert_unreached: onerror should not fire. Reached unreachable code
11:25:26     INFO - EventHandlerNonNull*assert_link_prefetches@http://web-platform.test:8000/content-security-policy/support/prefetch-helper.js:33:18
11:25:26     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:22:9
11:25:26     INFO - EventListener.handleEvent*@http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:12:7
11:25:26     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20
11:25:26     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:561:13
11:25:26     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:9:5
11:25:26     INFO - TEST-OK | /content-security-policy/prefetch-src/prefetch-allowed.html | took 282ms

    
    

    
      
  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Disable on Win10
        — 
          — Splinter Review
      

    


  
There are 184 failures in the last 7 days.
Most of them on Windows10-64 (182 failure).
Attached a patch to disable it on Windows10-64 too.

        Attachment #9006168 -
        Flags: review?(gbrown)

        Attachment #9006168 -
        Flags: review?(gbrown) → review+

    
    

    
  
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bee5ed43a0f9
Disable prefetch-allowed.html on Win10 for frequent failures. r=gbrown
Whiteboard: [domsecurity-intermittent][retriggered][stockwell disable-recommended] → [domsecurity-intermittent][retriggered][stockwell disabled]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
In the last 7 days, there have been 31 failures.

Most of the failures are on windows10-64 opt.


An example of a recent log file: https://treeherder.mozilla.org/logviewer.html#?job_id=201152812&repo=mozilla-inbound&lineNumber=1315

And the relevant part of the log:
09:33:36     INFO - TEST-START | /content-security-policy/prefetch-src/prefetch-allowed.html
09:33:36     INFO - Setting pref security.mixed_content.upgrade_display_content (false)
09:33:37     INFO - 
09:33:37     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports prefetch. 
09:33:37     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports performance APIs. 
09:33:37     INFO - TEST-UNEXPECTED-FAIL | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - assert_unreached: onerror should not fire. Reached unreachable code
09:33:37     INFO - EventHandlerNonNull*assert_link_prefetches@http://web-platform.test:8000/content-security-policy/support/prefetch-helper.js:33:18
09:33:37     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:22:9
09:33:37     INFO - EventListener.handleEvent*@http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:12:7
09:33:37     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1573:20
09:33:37     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:576:13
09:33:37     INFO - @http://web-platform.test:8000/content-security-policy/prefetch-src/prefetch-allowed.html:9:5
09:33:37     INFO - TEST-OK | /content-security-policy/prefetch-src/prefetch-allowed.html | took 296ms
09:33:37     INFO - PID 824 | 1537781617268	Marionette	INFO	Stopped listening on port 2828
09:33:37     INFO - PID 824 | [Child 7968, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Child 7968, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | JavaScript error: resource://onboarding/onboarding.js, line 29: NS_ERROR_NOT_AVAILABLE:
09:33:37     INFO - PID 824 | [Parent 824, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Child 7804, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Child 7804, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Parent 824, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Child 7232, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Child 7232, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
09:33:37     INFO - PID 824 | [Parent 824, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 188
09:33:37     INFO - PID 824 | JavaScript error: resource:///modules/AsyncTabSwitcher.jsm, line 256: TypeError: browser.frameLoader is null
09:33:37     INFO - Browser exited with return code 0
09:33:37  WARNING - u'runner_teardown': ()
09:33:37     INFO - Setting up ssl
09:33:37     INFO - certutil | 
09:33:37     INFO - certutil | 
09:33:37     INFO - certutil | 
09:33:37     INFO - Certificate Nickname                                         Trust Attributes
09:33:37     INFO -                                                              SSL,S/MIME,JAR/XPI
09:33:37     INFO - 
09:33:37     INFO - web-platform-tests                                           CT,, 
09:33:37     INFO - 
09:33:37     INFO - Application command: Z:\task_1537780626\build\application\firefox\firefox.exe -marionette about:blank -profile c:\users\task_1537780626\appdata\local\temp\tmp2irl2o.mozrunner
09:33:37     INFO - Starting runner
09:33:39     INFO - PID 5716 | 1537781619628	Marionette	INFO	Listening on port 2828

::ckerschb As you are the triage owner of this component, could you please take a look at this?
Thank you!
Flags: needinfo?(ckerschb)
Whiteboard: [domsecurity-intermittent][retriggered][stockwell disabled] → [domsecurity-intermittent][retriggered][stockwell disabled][stockwell-needswork]

    
    

    
  
(In reply to Cristina Coroiu [:ccoroiu] from comment #50)
> ::ckerschb As you are the triage owner of this component, could you please
> take a look at this?
> Thank you!

Hey Chrstina,
we don't support prefetch-src as of now within Firefox. If that 'allowed' test is adding too much useless noise to our testing infrastructure then I am fine with completely disabling that wpt test. Can you disable it for us please?
Flags: needinfo?(wleung)
Flags: needinfo?(ckerschb)
Flags: needinfo?(ccoroiu)

    
    

    
  
We usually disable a test when an intermittent-failure bug has recorded 150 or more failures in the last 21 days. 
:gbrown could you please take a look?
Flags: needinfo?(ccoroiu) → needinfo?(gbrown)

    
    

    
  
Looking at Orange Factor, there is a decrease since 25th September and the last failure is from 26th September, we'll keep an eye and if needed we'll create a patch for disabling.

Regards

    
    

    
  
Recall that this test was already disabled on Windows 10 in comment 45. I think I see a typo in that patch; I'll try to fix it.
Flags: needinfo?(gbrown)

    
    

    
  
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/634a0cbc28af
Fix typo in wpt ini file for prefetch-allowed.html; r=me,a=test-only

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  
Whiteboard: [domsecurity-intermittent][retriggered][stockwell disabled][stockwell-needswork] → [domsecurity-intermittent][retriggered][stockwell disabled]

    
  
Severity: normal → S3

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: