1449490 - [Wayland] implement gtk_clipboard_request_text() on wayland

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

We need to implement gtk_clipboard_request_text() on wayland clipboard backend to get text pasted correctly.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

X11 counterpart is Bug 1447925.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1449490 - [Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(),

Review commit: https://reviewboard.mozilla.org/r/231910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231910/

Comment 3

[Martin Stránský [:stransky] (ni? me)]

We need nsDataOffer implementation (Bug 1417892) to land first.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8963050 [details]
Bug 1449490 - [Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231910/diff/1-2/

Comment 5

[Jan Horak [:jhorak]]

Comment on attachment 8963050 [details]
Bug 1449490 - [Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(),

https://reviewboard.mozilla.org/r/231910/#review240556

::: widget/gtk/nsClipboardWayland.cpp:729
(Diff revision 2)
> +    GdkAtom selection = GetSelectionAtom(aWhichClipboard);
> +    DataOffer* dataOffer = (selection == GDK_SELECTION_PRIMARY) ?
> +                              mPrimaryOffer : mClipboardOffer;
> +
> +    for (unsigned int i = 0; i < sizeof(sTextMimeTypes); i++) {
> +        if (dataOffer->HasTarget(sTextMimeTypes[i])) {

Can we ensure that dataOffer is not null there or better test it befor the for loop?

::: widget/gtk/nsClipboardWayland.cpp:730
(Diff revision 2)
> +    DataOffer* dataOffer = (selection == GDK_SELECTION_PRIMARY) ?
> +                              mPrimaryOffer : mClipboardOffer;
> +
> +    for (unsigned int i = 0; i < sizeof(sTextMimeTypes); i++) {
> +        if (dataOffer->HasTarget(sTextMimeTypes[i])) {
> +            uint32_t tmp;

name it 'unused' instead of 'tmp' to make it clear that it's actually not used anywhere.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8963050 [details]
Bug 1449490 - [Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231910/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b17d0621e2d1
[Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(), r=jhorak

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b17d0621e2d1

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8963050 [details]
Bug 1449490 - [Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(),

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1447925
[User impact if declined]: Wayland backend fails to build
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: This code is build by distros only for Wayland backend. Mozilla does not ship that.
[String changes made/needed]: none

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Martin, from comment 3, do you also need to uplift from bug 1417892?

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Martin, from comment 3, do you also need to uplift from bug 1417892?

Thanks Liz, I was mistaken here. We also need bug 1417892 for this one. I'll file the uplift request.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8963050 [details]
Bug 1449490 - [Wayland] Implement gtk_clipboard_request_text() by nsRetrievalContextWayland::GetClipboardText(),

NPOTB, used by other distros, Beta60+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/344e70fd7bcd