1449499 - Intermittent /webdriver/tests/fullscreen_window.py | test_handle_prompt_missing_value - JavascriptErrorException: javascript error (500): ReferenceError: accept1 is not defined

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Running the test locally fails with:

>         if response.status != 200:
> >           raise error.from_response(response)
> E           JavascriptErrorException: javascript error (500): ReferenceError: accept1 is not defined
> E
> E           Remote-end stacktrace:
> E
> E           execute_script @, line 0
> E           inline javascript, line 1
> E           src: "undefined"
> E           Stack:
> E           @http://web-platform.test:8000/webdriver/tests/support/inline.py?doc=%3Ctitle%3EWD+doc+title%3C%2Ftitle%3E&content-type=text%2Fhtml%3Bcharset%3Dutf-8:1:15
> E           @http://web-platform.test:8000/webdriver/tests/support/inline.py?doc=%3Ctitle%3EWD+doc+title%3C%2Ftitle%3E&content-type=text%2Fhtml%3Bcharset%3Dutf-8:1:2
> 
> body       = {'args': [], 'script': 'return accept1;'}
> method     = 'POST'
> response   = <Response status=500 error=<JavascriptErrorException http_status=500>>
> self       = <webdriver.client.Session object at 0x10f00d390>
> url        = 'session/8a9cee76-bf44-9740-99c4-f5113fadff46/execute/sync'
> 
> testing/web-platform/tests/tools/webdriver/webdriver/client.py:435: JavascriptErrorException

Sadly this failure is not noticed because we marked the test as expected failure due to the unfinished alert handling. And as such it is never reported as actual failure on Treeherder, and causes following tests (see bug 1396180) to fail.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The line which fails here is:

https://hg.mozilla.org/mozilla-central/annotate/b906009d875d1f5d29b0d1252cdb43a9b1a5889c/testing/web-platform/tests/webdriver/tests/fullscreen_window.py#l124

> assert read_global(session, "accept1") == None

It was added via bug 1388036 when the fullscreen tests have been added.

So `accept1` is clearly not defined because the value gets assigned as `dismiss1`:

> create_dialog("alert", text="dismiss #1", result_var="dismiss1")

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Henrik Skupin (:whimboo) from comment #0)
> Sadly this failure is not noticed because we marked the test as expected
> failure due to the unfinished alert handling. And as such it is never

Well, I was wrong! The failure was only flagged as expected because of THIS javascript error. It basically should not have happened. We should analyze failures more carefully to prevent those situations. I will remove the unexpected fail from the manifest file.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1449499 - Fix fullscreen_window.py:test_handle_prompt_missing_value for wrong dialog reference.

Review commit: https://reviewboard.mozilla.org/r/231868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231868/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8963028 [details]
Bug 1449499 - Fix fullscreen_window.py:test_handle_prompt_missing_value for wrong dialog reference.

https://reviewboard.mozilla.org/r/231868/#review237458

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/282fa6844858
Fix fullscreen_window.py:test_handle_prompt_missing_value for wrong dialog reference. r=ato

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/282fa6844858

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Typo in a test which caused us to inappropriately disable a test. Lets uplift this test-only patch to beta. Thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/50c2162dfe7f