Closed Bug 1449528 Opened 2 years ago Closed 2 years ago

CSS Grid Inspector: Arrows should always point down the line

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: mbalfanz, Assigned: mbalfanz)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Currently, when the grid is close to the edge of the viewport, the line markers flip around and point outside of the container. This way they no longer point at the line, but somewhere else.

A suggested fix is to move the markers inside the grid, but keep the arrow direction as is, pointing a long the line. This will make it easier for the user to follow the line direction.

Please find examples of the current situation on page 1, and a mockup of the suggestion page 2 & 3 of the attached PDF document.
Blocks: dt-grid
Priority: -- → P3
Attached patch 1449528.patch (obsolete) — Splinter Review
Attachment #8963274 - Flags: feedback?(gl)
Assignee: nobody → mbalfanz
Status: NEW → ASSIGNED
Blocks: 1449568
Attached patch 1449528.patchSplinter Review
Attachment #8963274 - Attachment is obsolete: true
Attachment #8963274 - Flags: feedback?(gl)
Attachment #8964882 - Flags: review?(gl)
Attachment #8964882 - Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c0b2e2a81d1
Don't rotate grid line number markers when close to the viewport edge. r=gl
https://hg.mozilla.org/mozilla-central/rev/1c0b2e2a81d1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.