CSS Grid Inspector: Arrows should always point down the line

RESOLVED FIXED in Firefox 61

Status

P3
normal
RESOLVED FIXED
11 months ago
8 months ago

People

(Reporter: mbalfanz, Assigned: mbalfanz)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 61
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 months ago
Created attachment 8963049 [details]
Grid Inspector Line Marker Flip.pdf

Currently, when the grid is close to the edge of the viewport, the line markers flip around and point outside of the container. This way they no longer point at the line, but somewhere else.

A suggested fix is to move the markers inside the grid, but keep the arrow direction as is, pointing a long the line. This will make it easier for the user to follow the line direction.

Please find examples of the current situation on page 1, and a mockup of the suggestion page 2 & 3 of the attached PDF document.

Updated

11 months ago
Blocks: 1181227
Priority: -- → P3
(Assignee)

Comment 1

11 months ago
Created attachment 8963274 [details] [diff] [review]
1449528.patch
Attachment #8963274 - Flags: feedback?(gl)
Assignee: nobody → mbalfanz
Status: NEW → ASSIGNED
(Assignee)

Updated

11 months ago
Blocks: 1449568
(Assignee)

Comment 2

11 months ago
Created attachment 8964882 [details] [diff] [review]
1449528.patch
Attachment #8963274 - Attachment is obsolete: true
Attachment #8963274 - Flags: feedback?(gl)
Attachment #8964882 - Flags: review?(gl)

Updated

10 months ago
Attachment #8964882 - Flags: review?(gl) → review+

Comment 3

10 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c0b2e2a81d1
Don't rotate grid line number markers when close to the viewport edge. r=gl

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c0b2e2a81d1
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.