Closed
Bug 1449540
Opened 7 years ago
Closed 6 years ago
Allow to change the prototype of ArrayBuffer objects
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: anba, Assigned: khyperia)
Details
Attachments
(1 file, 1 obsolete file)
3.09 KB,
patch
|
khyperia
:
review+
|
Details | Diff | Splinter Review |
bug 950407 disallowed to change the [[Prototype]] of ArrayBuffer objects because of "their complicated delegate-object shenanigans" [1]. But that's probably no longer true since bug 979480.
[1] https://searchfox.org/mozilla-central/rev/028cd8342899357d80fafba2d528a0fd5819e316/js/src/vm/JSObject.cpp#2646-2655
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → khyperia
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9002603 -
Flags: review?(jorendorff)
Comment 2•6 years ago
|
||
Comment on attachment 9002603 [details] [diff] [review]
Allow modification of ArrayBuffer's __proto__.
Review of attachment 9002603 [details] [diff] [review]:
-----------------------------------------------------------------
yep
Attachment #9002603 -
Flags: review?(jorendorff) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ce115e1803
Allow modification of ArrayBuffer's __proto__. r=jorendorff
Keywords: checkin-needed
Comment 4•6 years ago
|
||
Backed out for failing jit and spidermonkey bustages
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d3ce115e1803ac4f85fef0568a7521e8ea2a87f7
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195163426&repo=mozilla-inbound&lineNumber=4593
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9abc7d4a76b8c53ba4f2f7aedeecddfe6f36984
Flags: needinfo?(khyperia)
Comment 5•6 years ago
|
||
Turns out you made some tests no longer throw errors.
Probably just need to change https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/auto-regress/bug666599.js#1
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Flags: needinfo?(khyperia)
Assignee | ||
Updated•6 years ago
|
Attachment #9002603 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #9003194 -
Flags: review+
Assignee | ||
Comment 8•6 years ago
|
||
Try run is passing, should be good to go again.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/145d39cf7ff2
Allow modification of ArrayBuffer's __proto__. r=jorendorff
Keywords: checkin-needed
Comment 10•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
status-firefox62:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•