Allow to change the prototype of ArrayBuffer objects

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
11 months ago
6 months ago

People

(Reporter: anba, Assigned: khyperia)

Tracking

Trunk
mozilla63
Points:
---

Firefox Tracking Flags

(firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 months ago
bug 950407 disallowed to change the [[Prototype]] of ArrayBuffer objects because of "their complicated delegate-object shenanigans" [1]. But that's probably no longer true since bug 979480.

[1] https://searchfox.org/mozilla-central/rev/028cd8342899357d80fafba2d528a0fd5819e316/js/src/vm/JSObject.cpp#2646-2655
Priority: -- → P3
(Assignee)

Updated

6 months ago
Assignee: nobody → khyperia
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 months ago
Created attachment 9002603 [details] [diff] [review]
Allow modification of ArrayBuffer's __proto__.
(Assignee)

Updated

6 months ago
Attachment #9002603 - Flags: review?(jorendorff)
Comment on attachment 9002603 [details] [diff] [review]
Allow modification of ArrayBuffer's __proto__.

Review of attachment 9002603 [details] [diff] [review]:
-----------------------------------------------------------------

yep
Attachment #9002603 - Flags: review?(jorendorff) → review+
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 3

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ce115e1803
Allow modification of ArrayBuffer's __proto__. r=jorendorff
Keywords: checkin-needed
Turns out you made some tests no longer throw errors. 

Probably just need to change https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/auto-regress/bug666599.js#1
(Assignee)

Comment 6

6 months ago
Created attachment 9003194 [details] [diff] [review]
Allow modification of ArrayBuffer's __proto__.
(Assignee)

Updated

6 months ago
Attachment #9002603 - Attachment is obsolete: true
(Assignee)

Updated

6 months ago
Attachment #9003194 - Flags: review+
(Assignee)

Comment 8

6 months ago
Try run is passing, should be good to go again.
Keywords: checkin-needed

Comment 9

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/145d39cf7ff2
Allow modification of ArrayBuffer's __proto__. r=jorendorff
Keywords: checkin-needed

Comment 10

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/145d39cf7ff2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
status-firefox61: affected → wontfix
status-firefox62: --- → wontfix
You need to log in before you can comment on or make changes to this bug.