1449540 - Allow to change the prototype of ArrayBuffer objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

bug 950407 disallowed to change the [[Prototype]] of ArrayBuffer objects because of "their complicated delegate-object shenanigans" [1]. But that's probably no longer true since bug 979480.

[1] https://searchfox.org/mozilla-central/rev/028cd8342899357d80fafba2d528a0fd5819e316/js/src/vm/JSObject.cpp#2646-2655

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Allow modification of ArrayBuffer's __proto__.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 9002603 [details] [diff] [review]
Allow modification of ArrayBuffer's __proto__.

Review of attachment 9002603 [details] [diff] [review]:
-----------------------------------------------------------------

yep

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ce115e1803
Allow modification of ArrayBuffer's __proto__. r=jorendorff

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing jit and spidermonkey bustages

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d3ce115e1803ac4f85fef0568a7521e8ea2a87f7

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195163426&repo=mozilla-inbound&lineNumber=4593

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9abc7d4a76b8c53ba4f2f7aedeecddfe6f36984

Comment 5

[Ted Campbell [:tcampbell]]

Turns out you made some tests no longer throw errors. 

Probably just need to change https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/auto-regress/bug666599.js#1

Comment 6

[Ashley Hauck [:khyperia]]

Attachment: Allow modification of ArrayBuffer's __proto__.

Comment 7

[Ashley Hauck [:khyperia]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4cbc49d83b5f947ab868b232e2a046f714dee78

Comment 8

[Ashley Hauck [:khyperia]]

Try run is passing, should be good to go again.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/145d39cf7ff2
Allow modification of ArrayBuffer's __proto__. r=jorendorff

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/145d39cf7ff2