Closed Bug 1449540 Opened 2 years ago Closed 2 years ago

Allow to change the prototype of ArrayBuffer objects

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: anba, Assigned: khyperia)

Details

Attachments

(1 file, 1 obsolete file)

bug 950407 disallowed to change the [[Prototype]] of ArrayBuffer objects because of "their complicated delegate-object shenanigans" [1]. But that's probably no longer true since bug 979480.

[1] https://searchfox.org/mozilla-central/rev/028cd8342899357d80fafba2d528a0fd5819e316/js/src/vm/JSObject.cpp#2646-2655
Priority: -- → P3
Assignee: nobody → khyperia
Status: NEW → ASSIGNED
Attachment #9002603 - Flags: review?(jorendorff)
Comment on attachment 9002603 [details] [diff] [review]
Allow modification of ArrayBuffer's __proto__.

Review of attachment 9002603 [details] [diff] [review]:
-----------------------------------------------------------------

yep
Attachment #9002603 - Flags: review?(jorendorff) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ce115e1803
Allow modification of ArrayBuffer's __proto__. r=jorendorff
Keywords: checkin-needed
Turns out you made some tests no longer throw errors. 

Probably just need to change https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/auto-regress/bug666599.js#1
Attachment #9002603 - Attachment is obsolete: true
Attachment #9003194 - Flags: review+
Try run is passing, should be good to go again.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/145d39cf7ff2
Allow modification of ArrayBuffer's __proto__. r=jorendorff
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/145d39cf7ff2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.