Closed Bug 144957 Opened 22 years ago Closed 22 years ago

Convert EditorSaveAsCharset to rdfliner

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows 95
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.2alpha

People

(Reporter: neil, Assigned: cmanske)

Details

Attachments

(1 file, 2 obsolete files)

Really updated patch this time!
8.86 KB, patch
janv
: review+
alecf
: superreview+
Details | Diff | Splinter Review
EditorSaveAsCharset currently enumerates the charsets from RDF and adds them into the content of the tree. However the tree can enumerate the charsets itself by adding the charsets as an RDF data source for the tree. This is a big perf win. The otherwise unused treelist functions can also be removed from EdDialogCommon.js
Attached patch Proposed patch (obsolete) — — Splinter Review
Keywords: patch, perf, review
Attached patch Updated patch (obsolete) — — Splinter Review
Fixed comments from Jan Varga: used charsetTree.builderView instead of explicit QI removed unnecessary sort attributes
Attachment #83856 - Attachment is obsolete: true
Fixed comments from Jan Varga: used charsetTree.builderView instead of explicit QI removed unnecessary sort attributes
Attachment #83862 - Attachment is obsolete: true
Comment on attachment 83863 [details] [diff] [review] Really updated patch this time! r=varga just place: onselect="SelectCharset() on a new line
Attachment #83863 - Flags: review+
Does anyone think this is a safe enough and a big enough win to consider for RTM?
Assignee: syd → cmanske
Target Milestone: --- → mozilla1.2beta
>Does anyone think this is a safe enough and a big enough win to consider for RTM? I don't think so.
Status: NEW → ASSIGNED
Keywords: nsbeta1
Whiteboard: [FIX IN HAND]need sr=
Target Milestone: mozilla1.2beta → mozilla1.2alpha
Comment on attachment 83863 [details] [diff] [review] Really updated patch this time! wow, suprisingly simple sr=alecf
Attachment #83863 - Flags: superreview+
Whiteboard: [FIX IN HAND]need sr= → [FIX IN HAND]
checked into 1.2 trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: patch, perf, review
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND]
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: