Convert EditorSaveAsCharset to rdfliner

RESOLVED FIXED in mozilla1.2alpha

Status

RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: neil, Assigned: cmanske)

Tracking

Trunk
mozilla1.2alpha
x86
Windows 95

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

17 years ago
EditorSaveAsCharset currently enumerates the charsets from RDF and adds them
into the content of the tree. However the tree can enumerate the charsets itself
by adding the charsets as an RDF data source for the tree. This is a big perf win.
The otherwise unused treelist functions can also be removed from EdDialogCommon.js
(Reporter)

Comment 1

17 years ago
Created attachment 83856 [details] [diff] [review]
Proposed patch
(Reporter)

Updated

17 years ago
Keywords: patch, perf, review
(Reporter)

Comment 2

17 years ago
Created attachment 83862 [details] [diff] [review]
Updated patch

Fixed comments from Jan Varga:
used charsetTree.builderView instead of explicit QI
removed unnecessary sort attributes
Attachment #83856 - Attachment is obsolete: true
(Reporter)

Comment 3

17 years ago
Created attachment 83863 [details] [diff] [review]
Really updated patch this time!

Fixed comments from Jan Varga:
used charsetTree.builderView instead of explicit QI
removed unnecessary sort attributes
Attachment #83862 - Attachment is obsolete: true

Comment 4

17 years ago
Comment on attachment 83863 [details] [diff] [review]
Really updated patch this time!

r=varga
just place: onselect="SelectCharset()
on a new line
Attachment #83863 - Flags: review+
(Assignee)

Comment 5

17 years ago
Does anyone think this is a safe enough and a big enough win to consider for RTM?
Assignee: syd → cmanske
Target Milestone: --- → mozilla1.2beta

Comment 6

17 years ago
>Does anyone think this is a safe enough and a big enough win to consider for RTM?
I don't think so.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1
Whiteboard: [FIX IN HAND]need sr=
Target Milestone: mozilla1.2beta → mozilla1.2alpha

Comment 7

16 years ago
Comment on attachment 83863 [details] [diff] [review]
Really updated patch this time!

wow, suprisingly simple
sr=alecf
Attachment #83863 - Flags: superreview+
(Assignee)

Updated

16 years ago
Whiteboard: [FIX IN HAND]need sr= → [FIX IN HAND]
(Assignee)

Comment 8

16 years ago
checked into 1.2 trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Keywords: patch, perf, review
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND]
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.