1449574 - Update to tzdata2018d

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect, P1)

Description

[André Bargull [:anba]]

Release notes:
http://mm.icann.org/pipermail/tz-announce/2018-March/000049.html

Comment 1

[Jason Orendorff [:jorendorff]]

This seems time-sensitive, so I bumped it to P1.

anba, What work is involved here? Do we have to coordinate with the rest of Gecko?

Comment 2

[André Bargull [:anba]]

(In reply to Jason Orendorff [:jorendorff] from comment #1)
> This seems time-sensitive, so I bumped it to P1.

Ignoring some fixes for past dates, tzdata2018d changes only the data for three time zones:
- Antarctica/Casey switches from +11 to +08. (Probably not too many Firefox users at this science station in Antarctica.)
- Asia/Gaza and Asia/Hebron started DST on March 24 instead of March 31. (This info was relayed way too late to the tzinfo maintainers, so Palestinian users potentially had to struggle with wrong computer clocks this week.)


> anba, What work is involved here?

Two scripts need to be run (one to update the ICU data blob and another one to update some SpiderMonkey tests):

  cd intl
  ./update-tzdata.sh -e $ICU60_BUILD_DIR/bin/icupkg 2018d
  cd ../js/src/builtin/intl/
  ./make_intl_data.py tzdata


> Do we have to coordinate with the rest of Gecko?

No that I know of.

Comment 3

[André Bargull [:anba]]

Attachment: bug1449574.patch

Update to tzdata2018d.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 8963674 [details] [diff] [review]
bug1449574.patch

Review of attachment 8963674 [details] [diff] [review]:
-----------------------------------------------------------------

Joy.

Comment 5

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8f9f101035372e92e7ff882b8258935c624354a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c21d6cad94c
Update tzdata in ICU data files to 2018d. r=Waldo

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3c21d6cad94c

Comment 8

[André Bargull [:anba]]

Attachment: bug1449574-beta.patch

Backport for Beta. (Needs a different patch because Beta uses ICU60.)

Comment 9

[André Bargull [:anba]]

Attachment: bug1449574-esr52.patch

Backport for ESR52. (Needs a different patch because ESR52 uses ICU58.)

Comment 10

[André Bargull [:anba]]

Comment on attachment 8964913 [details] [diff] [review]
bug1449574-beta.patch

Approval Request Comment
[Feature/Bug causing the regression]: N/A

[User impact if declined]:
Wrong or inconsistent time zone data when calling methods from Intl.DateTimeFormat or methods internally using Intl.DateTimeFormat (that means Date.prototype.toLocale(Date|Time)String()). Inconsistencies are possible when the OS already uses the current tzdata release (tzdata 2018d), but our internal ICU version still uses tzdata 2018c. 
Based on the release notes for tzdata 2018d <https://mm.icann.org/pipermail/tz-announce/2018-March/000049.html>, the update is of special interest for users in Palestine (starting this year, DST now begins on the first Saturday after 21st March). And possibly for researchers at the Casey Station in Antarctica (time zone changed from +11 to +08).

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
None.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It only updates time zone data files.

[String changes made/needed]:
No.

Comment 11

[André Bargull [:anba]]

Comment on attachment 8964914 [details] [diff] [review]
bug1449574-esr52.patch

[Approval Request Comment]

If this is not a sec:{high,crit} bug, please state case for ESR consideration:

User impact if declined: 
See comment #10.

Fix Landed on Version:
Firefox 61; Firefox 60 see comment #10.

Risk to taking this patch (and alternatives if risky): 
See comment #10.

String or UUID changes made by this patch: 
No.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8964913 [details] [diff] [review]
bug1449574-beta.patch

Timezone data update needed to avoid returning incorrect results for various methods. Approved for 60.0b11 and ESR 52.8.0.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a2a113d5cfe

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/ff0a4c522f89