14496 - Clicking on MIDI file link doesn't play in Quicktime

Status: VERIFIED DUPLICATE of bug 35682

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Zach Kantola]

Everytime a midi file attemps to load, I get this message:
APPRUNNER caused an invalid page fault in
module RAPTORPLUGIN.DLL at 015f:60a2182b.
Registers:
EAX=60a26270 CS=015f EIP=60a2182b EFLGS=00010246
EBX=02c62450 SS=0167 ESP=0063fa68 EBP=0063fa80
ECX=0063fa7c DS=0167 ESI=00000000 FS=32ff
EDX=00000008 ES=0167 EDI=80000000 GS=0000
Bytes at CS:EIP:
8b 06 51 56 ff 50 38 bf 00 00 00 80 85 c7 0f 85
Stack dump:
80000000 02c34250 02c62450 00000000 000003f4 00000000 0063faa4 604b476c 02c62450
00000000 00000000 80000000 02c344f0 02c3450c 02c666e0 0063fad4

Comment 1

[Eli Goldberg]

[e-mail], could you please provide steps to reproduce this bug, as
described in the Bug Writing Guidelines? (http://www.mozilla.org/quality/bug-
writing-guidelines.html)

Are you using a 3rd party audio plug-in? Could you cite an example of how you are
triggering the playing of a midi file? (there are several ways, and I'm not
certain which you're referring to.)

Thanks!

Comment 2

[av (gone)]

I used this URL:
http://www.acronet.net/~robokopp/eire/odannybo.htm
click on Melody once there.

I saw the crash with different audio plugins.

Comment 3

[Eli Goldberg]

Thanks, Andrei, for filling in the main holes in this bug report.

Confirmed that:
	* 9.21.99 build of Seamonkey using npaudio.dll plug-in results in a crash
using the specified URL [on NT 4.0 SP5, no audio]

	* 10.1.99 build of Seamonkey using npaudio.dll plug-in results in the not-
quite-crash described in bug #6113.

Thus, verified.

Comment 4

[Eli Goldberg]

I must be smoking dope. More likely, I'm not used to seeing bugs being marked as
Resolved without a comment in the bug report, and am verifying bugs whose fixes
haven't yet been added to the build.

Anyway, using today's build, this still crashes with the npaudio.dll and
npaudio.zip files in Plugins. Will verify on Monday.

Comment 5

[Eli Goldberg]

[bug #6113 occurs if no audio plug-in is present.]

Comment 6

[av (gone)]

Sorry, Eli, I should not be that lazy not telling you... I checked in the fix
today around 1pm. Be prepared that LiveAudio will not play the sound but this is
different issue.

Comment 7

[Eli Goldberg]

Hey, Andrei ---

This appears fixed in the 1999100708 Win32 commercial build.

However, I receive the following crash upon viewing the page with the Mozilla
build of the same date on Mac OS, with the 1.0.4 LiveAudio plug-in; please let me
know if you'd like me to break it into a separate bug. Thanks!

----


PowerPC read-only memory exception at 0E00C914 NQDOffsetRgn+00030
 Calling chain using A6/R1 links
  Back chain  ISA  Caller
  00000000    PPC  0DADF360
  054A8FC0    PPC  0DADC720  main+00114
  054A8F50    PPC  0DADC3E4  main1(int, char**)+00818
  054A8D90    PPC  0D97091C  nsAppShellService::Run()+00018
  054A8D50    PPC  0D941870  nsAppShell::Run()+00038
  054A8CD0    PPC  0D942328  nsMacMessagePump::DoMessagePump()+0003C
  054A8C80    PPC  0D9425E0  nsMacMessagePump::DispatchEvent(int, EventRecord*)+
00158
  054A8C30    PPC  0DA97458  Repeater::DoRepeaters(const EventRecord&)+00030
  054A8BF0    PPC  0D925610  nsMacNSPREventQueueHandler::RepeatAction(const
EventRecord&)+000
20
  054A8BB0    PPC  0D77A19C  nsEventQueueServiceImpl::ProcessEvents()+00020
  054A8B70    PPC  0D775AF0  nsHashtable::Enumerate(int (*)(nsHashKey*, void*,
void*), void*)
+00024
  054A8B30    PPC  0D83F884  PL_HashTableEnumerateEntries+00060
  054A8AC0    PPC  0D775414  _hashEnumerate(PLHashEntry*, int, void*)+00024
  054A8A80    PPC  0D77A10C  EventDispatchingFunc(nsHashKey*, void*, void*)+0002C
  054A8A40    PPC  0D78BD28  nsEventQueueImpl::ProcessPendingEvents()+00010
  054A8A00    PPC  0D83EC78  PL_ProcessPendingEvents+00078
  054A89B0    PPC  0D83ED18  PL_HandleEvent+00028
  054A8970    PPC  0D8E39EC  nsStreamListenerEvent::HandlePLEvent(PLEvent*)+E39EC
  054A8920    PPC  0D8E470C  nsOnDataAvailableEvent::HandleEvent()+E470C
  054A88D0    PPC  0D7F753C  nsHTTPResponseListener::OnDataAvailable(nsIChannel*,
nsISupports
*, nsIInputStream*, unsigned int, unsigned int)+F753C
  054A8850    PPC  0D7F84AC  nsHTTPResponseListener::FinishedResponseHeaders()+
F84AC
  054A8800    PPC  0DAC3A94  nsChannelListener::OnStartRequest(nsIChannel*,
nsISupports*)+002
80
  054A8630    PPC  0DAC2CF8  nsDocumentBindInfo::OnStartRequest(nsIChannel*,
nsISupports*)+00
1C8
  054A85C0    PPC  0CA7AC0C  PluginListener::OnStartRequest(nsIChannel*,
nsISupports*)+7AC0C
  054A8570    PPC  0CA79CC0  PluginViewerImpl::StartLoad(nsIChannel*,
nsIStreamListener*&)+79
CC0
  054A84F0    PPC  0CA79EF8  PluginViewerImpl::CreatePlugin(nsIPluginHost*, const
nsRect&, ns
IStreamListener*&)+79EF8
  054A83E0    PPC  0D3E6DA4  nsPluginHostImpl::InstantiateFullPagePlugin(const
char*, nsStrin
g&, nsIStreamListener*&, nsIPluginInstanceOwner*)+001C0
  054A8380    PPC  0D3DF138  ns4xPluginInstance::SetWindow(nsPluginWindow*)+00060
  054A8330    PPC  0D2D3850  Private_SetWindow(_NPP*, _NPWindow*)+00020
  054A82F0    PPC  0D2CBAA8  NPP_SetWindow+0009C
  054A82A0    PPC  0D2CD39C  DrawSplashScreen(_SoundPluginInstance*, unsigned
char)+0004C
  054A8240    PPC  0D2CC5BC  StartDraw(_SoundPluginInstance*)+00164
  054A81E0    PPC  FFD5C6A0  SetOrigin+0001C
  054A81A0    PPC  0E0044F8  NQDSetOrigin+000E4
 Closing log

Comment 8

[av (gone)]

Eli, could you please try this with anything else rather than LiveAudio?

Comment 9

[Eli Goldberg]

Sure. Doing now...

Comment 10

[Eli Goldberg]

Win32 (1999110809):
	Using QuickTime (4.0.3), MIDI files play correctly.

Mac OS (1999110808):
	Using QuickTime (4.0.3), MIDI files (that load properly in 4.x) don't load
at all; the browser never proceeds beyond "Transferring data from...". To see an
example, try loading http://www.prometheus-music.com/gecko/KQ4GS1.mid.

	I assume this is happening for a different reason, but would prefer being
sure before verifying the bug.

	Thanks!

Comment 11

[Pierre Saslawsky]

Eli: I can't connect to Prometheus on the Mac with Communicator as well as
AppRunner.

Comment 12

[Eli Goldberg]

Hrf. I'd try again, and see if works now; it's just a best.com hosted domain name
off of their servers, and very rarely has any downtime. (Yes, did re-confirm that
the URL in bug was correct.)

Comment 13

[Eli Goldberg]

Shrirang is now QA owner for Plug-ins; QA assigning all of my Plug-ins bugs over
to him.

Comment 14

[shrirang khanzode]

using today's commercial build, I do not see the crash. but the page does not
load at all and after some time a "Unknown File Type" doalog opens up.

Comment 15

[av (gone)]

It works for Windows so I am changing platform to Mac. Shrirang, could you
please try it on the latest build? I don't have a Mac handy.

Comment 16

[shrirang khanzode]

Am waiting for a workable build on MAC. Will verify as soon as one turns up.
Thanks!

Comment 17

[shrirang khanzode]

Used today's commercial build on Mac OS (2000011208):
Using QuickTime (4.0.3)plugin, MIDI files (that load properly in 4.x) don't load
at all. The status bar does not stop loading and the "Document:Done" message
appears but the page does not load.

Comment 18

[leger]

Adding "crash" keyword to all known open crasher bugs.

Comment 19

[av (gone)]

Shrirang, does this still happening?

Comment 20

[shrirang khanzode]

I tried to use quicktime plugin to play midi files but the browser crashes when 
I click on a midi link. I had reopened bug 24718 for the same problem. 

Comment 21

[rickg]

Top priority bug for m16

Comment 22

[Mike]

Attachment: Test MIDI File

Comment 23

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 24

[Peter Lubczynski]

adding myself to the CC:

BTW, on a Mac without any plugins using 10/14, a helper app launches when trying
to play MIDI even though I have Quicktime 4 installed. Is there something I'm
missing?

Comment 25

[ekrock's old account (dead)]

shrir: Can you still reproduce this bug? If not, we should probably resolve
WORKSFORME at this point.

peterl: When you say "a helper app launches," do you mean "a helper app other
than QuickTime?" QuickTime is itself a helper app, right? And you mean you're
seeing some other help other than it? (AFAIK, QuickTime always launches in its
own window as a helper app, and never displays content inside the web page as a
plug-in.)

The Netscape LiveAudio plug-in was discontinued long, long ago (in a galaxy far,
far away ...) -- any bug that is truly LiveAudio-specific should be marked WONTFIX.

Comment 26

[shrirang khanzode]

Eric, Quicktime is just like realplayer. Both products contain the browser 
plugin as well as a seperate application and both work (embedded and seperate). 
I will try this bug on today's mac and comment.

Comment 27

[Jason Eager]

Adding to Mozilla0.9 radar to see if we can get more verification cycles going
on this bug. First of all, we need to verify if this still causes a browser
crash on a mac.

Comment 28

[shrirang khanzode]

reassign :peterl. I tried this on today's trunk build on mac and see that on 
clicking on this url, the .mid file just gets downlaoded on my desktop and 
nothing else happens. Quicktime does not play this file ( even though it is set 
to handle this mime type) 

Comment 29

[Peter Lubczynski]

This seems to be a problem with using Quicktime as a full-page plugin because
the following testcases should show that playing embedded MIDI files with
Quicktime works.

Changing summary and keywords as we no longer crash.

Also, if you save the MIDI file locally, then double click on it, it will open
in Quicktime after going through some kind of translation. However, telling
Mozilla to "Open" the file with Quicktime doesn't do the translation and
therefore Quicktime says the file is unsupported. Adding Quicktime keyword.

Comment 30

[Peter Lubczynski]

Attachment: test case with embedded MIDI

Comment 31

[Peter Lubczynski]

By changing the #define PLUGIN_DLL in nsPluginHostImpl.cpp to go to 
pluginDebug.shlb, I am able to hear MIDI files play, but I can't see them. It's 
the same common problem among all full-page plugins on Mac.

Comment 32

[Peter Lubczynski]

Attachment: patch to correctly define PLUGIN_DLL

Comment 33

[Peter Lubczynski]

With this above patch, you should be able to at least "hear" the MIDI file. 
However, more work still needs to be done so you can "see" full-page plugins.

Comment 34

[Peter Lubczynski]

Changing peterl-retired to peterlubczynski

Comment 35

[Jesse Mehrbach]

On my Macintosh, running Build 2001011208, pages with embedded midi cause
Mozilla to crash, reporing an unexpected quit with a type 2 error.

Comment 36

[Jesse Mehrbach]

The crash I reported above only occurs without a midi plugin, and thus may not
be relevant to this bug.

Comment 37

[Peter Lubczynski]

Doesn't crash with the Quicktime plugin. Plays with the patch (19950) attched. 
What plugin were you using to play MIDI files?

Comment 38

[Jesse Mehrbach]

The crash only occurs without any midi plugin at all.  Of course, it is not
expected to play, but it shouldn't crash either.

Comment 39

[Peter Lubczynski]

I don't quite understand? If there is no MIDI plugin or Quicktime plugin then 
Mozilla will not know what to do with the file and bring up an Open/Save dialog. 
 This works for me. 

Visit about:plugin to see if any plugin is mapping into MIDI files. Also, try a 
recent build as many plugin changes when in last week.

Comment 40

[Jesse Mehrbach]

Thank you; the problem does not occur in the most recent build.

Comment 41

[Peter Lubczynski]

*** This bug has been marked as a duplicate of 35682 ***

Comment 42

[Chad Austin]

Lots of verifications.

If I had to test stuff, it was on Win2K, build id 2001052404.