1449614 - Firefox Notes' "Send to Notes" context menu option no longer works on the latest Beta and Nightly

Status: RESOLVED INVALID

(WebExtensions :: General, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

**[Affected versions]:**
- Firefox Beta (60.0b3) and above

**[Affected Platforms]:**
- All Windows
- All Mac
- All Linux

**[Prerequisites]:**
- Have a Firefox profile with the latest version of the "Firefox Notes" add-on (4.0.0 Beta 3) installed from https://goo.gl/h4nBSN.
- The "Firefox Notes" sidebar is opened in the list view mode.
- Have any website opened.

**[Steps to reproduce]:**
1. Open the browser with the profile from prerequisites.
2. Select any text from the opened website and right click on it.
3. Click the "Send to Notes" option and observe the behavior.

**[Expected result]:**
- The selected text is displayed in the sidebar in a new note.

**[Actual result]:**
- The sidebar flickers and the selected text is not added as a new note.

**[Regression window]:**
Last good revision: 7433031c9274b8299c3e2d50613de74352684bc1
First bad revision: 95a6bd5b90452da6eee11eb8ee53ef80c91565c6
INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7433031c9274b8299c3e2d50613de74352684bc1&tochange=95a6bd5b90452da6eee11eb8ee53ef80c91565c6

**[Additional Notes]:**
- If a note is opened when the "Send to Notes" context menu option is clicked, the sidebar goes back in the list view mode. In this case the text should have been added to the opened note.
- If the sidebar is closed when the "Send to Notes" context menu option is selected, the sidebar is opened in the list view mode. In this case the selected text should have been added as a new note.
- The issue is not reproducible with the TxP version of "Firefox Notes".
- Attached a screen recording of the issue.

Comment 1

[Shane Caraveo (:mixedpuppy)]

I'm confused.  Are you testing with b3?  Bug 1445080 comment 16 says this is fixed in b5.

Comment 2

[Marius Coman [:mcoman], Ecosystem QA]

Hi Shane,
Yes, it is fixed for the "Firefox Notes" 3.1.0 version (the version from the TxP website). However the Notes extension has been changed a lot lately and the 4.0.0 Beta 3 version is affected again.

Comment 3

[Shane Caraveo (:mixedpuppy)]

(In reply to Marius Coman [:cmarius] from comment #2)
> Hi Shane,
> Yes, it is fixed for the "Firefox Notes" 3.1.0 version (the version from the
> TxP website). However the Notes extension has been changed a lot lately and
> the 4.0.0 Beta 3 version is affected again.

From your report:

**[Affected versions]:**
- Firefox Beta (60.0b3) and above

What firefox version are you testing with?  If it's the latest firefox beta and this is a change due to updates in the extension, then I would think it is an extension bug.

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

Hi Shane,

This issue was first identified using version 3.1.0 of Notes and was a regression caused by bug 1398713. It was fixed and verified in Bug 1445080 using the same Notes version. 
Meanwhile we have a new Firefox Notes version (4.0.0) with a lot of changes and it seems that the issue is reproducible again.

However I'm not sure if this behavior is caused by some changes in the extension so I will also forward your question to the "Notes" team.

To reiterate:
1. The issue is reproducible with Notes 3.1.0 on beta 3 and no longer reproducible with Notes 3.1.0 on beta 7.
2. The issue is reproducible with Notes 4.0.0 on all beta builds.

Comment 5

[Shane Caraveo (:mixedpuppy)]

This is a problem  in notes.  I provided a fix.

https://gist.github.com/mixedpuppy/61bfc082fff115c851ea5449d2c6343f