1449653 - Implement a dark theme for snippets

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ricky Rosario [:rrosario, :r1cky]]

Spinoff from bug 1402312.

We need to change the template styles for snippets to use the theme CSS variables and possibly create some new ones.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4120

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

snippets-service PR:
https://github.com/mozmeao/snippets-service/pull/385/files

snippets PR:
https://github.com/mozmeao/snippets/pull/144/files

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b9ac05b84e1e2fbf79a28ea291c0d1aac3cbd58d
Fix Bug 1449653 - Implement a dark theme for snippets

https://github.com/mozilla/activity-stream/commit/e462340ba773a5611f31822e71a4e5b2bed9c56d
Merge pull request #4120 from rlr/Bug1449653/dark-theme

Fix Bug 1449653 - Implement a dark theme for snippets

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

This isn't quite fixed yet. Only the A-S changes have landed. The changes from comment 2 still need to land.

That said, bug 1456496 is now unblocked.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

The snippets side patches have been merged:

snippets-service: https://github.com/mozmeao/snippets-service/commit/90611b8da49e5a50a69e7d7a45a411509886952b
snippets: https://github.com/mozmeao/snippets/commit/235b00cb7709a236b0eb80998af6a0214f9b27d3

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/79ab9d325994

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to 61?

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

This actually is fixed in 61. Not sure why it was set like that? I guess because the bug was closed after 61 went to beta but the client side changes had already landed.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Which bug was that in? Bug 1462427 landed on the 18th AFAICT (after the version bump)?

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

From what I can tell, it went in Bug 1457192. There appears to be a bookkeeping bug here.

I see the changes from Comment 3 in https://searchfox.org/mozilla-central/diff/2d7d260a1e6fc94246bf651b364eae3f56a84e08/browser/extensions/activity-stream/css/activity-stream-windows.css#110-111 which is Bug 1457192

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Thanks for double-checking. Activity Stream patches are indeed a pain to keep track of :(

Comment 12

[Ed Lee :Mardak]

Ah indeed. Looks like it was incorrectly associated to the other export as the bug was reopened and only resolved after the snippets changes in comment 5.

https://hg.mozilla.org/mozilla-central/rev/9edd64fc07d3