Closed
Bug 1449806
Opened 4 years ago
Closed 4 years ago
Remove GenericSpecifiedValues
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: xidorn, Assigned: emilio)
References
Details
Attachments
(10 files)
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
|
Details |
After the old style system got removed, we can replace GenericSpecifiedValues with just ServoSpecifiedValues everywhere.
Updated•4 years ago
|
Priority: -- → P3
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → emilio
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 11•4 years ago
|
||
mozreview-review |
Comment on attachment 8987131 [details] Bug 1449806: Introduce MappedDeclarations. https://reviewboard.mozilla.org/r/252354/#review259058 ::: layout/style/MappedDeclarations.h:23 (Diff revision 1) > +// This provides a common interface for attribute mappers > +// (MapAttributesIntoRule) to use regardless of the style backend. If the style > +// backend is Gecko, this will contain an nsRuleData. If it is Servo, it will be > +// a PropertyDeclarationBlock. This comment should be updated, I guess. The old style system is no longer relevant. ::: layout/style/MappedDeclarations.h:43 (Diff revision 1) > + return mDocument; > + } > + > + already_AddRefed<RawServoDeclarationBlock> TakeDeclarationBlock() > + { > + return mDecl.forget(); Maybe add an assertion here that mDecl isn't double taken, and another assertion in destructor that mDecl has been taken. ::: layout/style/MappedDeclarations.h:210 (Diff revision 1) > + RefPtr<RawServoDeclarationBlock> mDecl; > +}; > + > +} // namespace mozilla > + > +#endif // mozilla_MappedDeclarations_h ::: layout/style/MappedDeclarations.cpp:7 (Diff revision 1) > +/* vim: set ts=8 sts=2 et sw=2 tw=80: */ > +/* This Source Code Form is subject to the terms of the Mozilla Public > + * License, v. 2.0. If a copy of the MPL was not distributed with this > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > + > +#include "MappedDeclarations.h" `"mozilla/MappedDeclarations.h"` Although they probably don't have difference effectively but it's probably better to keep consistency. ::: layout/style/MappedDeclarations.cpp:41 (Diff revision 1) > + aValue.ToString(str); > + Servo_DeclarationBlock_SetBackgroundImage( > + mDecl, str, mDocument->DefaultStyleAttrURLData()); > +} > + > + I don't think we need two empty lines here.
Attachment #8987131 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 12•4 years ago
|
||
mozreview-review |
Comment on attachment 8987132 [details] Bug 1449806: Fix function declarations in headers. https://reviewboard.mozilla.org/r/252356/#review259062
Attachment #8987132 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 13•4 years ago
|
||
mozreview-review |
Comment on attachment 8987133 [details] Bug 1449806: Fix cpp signatures and forwarding. https://reviewboard.mozilla.org/r/252358/#review259064
Attachment #8987133 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 14•4 years ago
|
||
mozreview-review |
Comment on attachment 8987134 [details] Bug 1449806: Fix cpp setters. https://reviewboard.mozilla.org/r/252360/#review259066
Attachment #8987134 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 15•4 years ago
|
||
mozreview-review |
Comment on attachment 8987135 [details] Bug 1449806: Fix PropertyIsSet checks. https://reviewboard.mozilla.org/r/252362/#review259068
Attachment #8987135 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 16•4 years ago
|
||
mozreview-review |
Comment on attachment 8987136 [details] Bug 1449806: Fix Document() accessors. https://reviewboard.mozilla.org/r/252364/#review259070
Attachment #8987136 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 17•4 years ago
|
||
mozreview-review |
Comment on attachment 8987137 [details] Bug 1449806: Fix up *Inlines.h includes. https://reviewboard.mozilla.org/r/252366/#review259074
Attachment #8987137 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 18•4 years ago
|
||
mozreview-review |
Comment on attachment 8987138 [details] Bug 1449806: Some manual fixes. https://reviewboard.mozilla.org/r/252368/#review259076
Attachment #8987138 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 19•4 years ago
|
||
mozreview-review |
Comment on attachment 8987139 [details] Bug 1449806: Final touch. https://reviewboard.mozilla.org/r/252370/#review259078
Attachment #8987139 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 20•4 years ago
|
||
mozreview-review |
Comment on attachment 8987140 [details] Bug 1449806: Remove MOZ_STYLO_* macros. https://reviewboard.mozilla.org/r/252372/#review259080 \o/
Attachment #8987140 -
Flags: review?(xidorn+moz) → review+
Comment 21•4 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ba328c141b7 Merge {Servo,Generic}SpecifiedValues into MappedDeclarations. r=xidorn https://hg.mozilla.org/integration/mozilla-inbound/rev/d535d6534b35 Remove MOZ_STYLO_* macros. r=xidorn
Comment 22•4 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac1b18d489e followup: Fix a typo that I made while addressing review comments. r=me CLOSED TREE
Comment 23•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5ba328c141b7 https://hg.mozilla.org/mozilla-central/rev/d535d6534b35 https://hg.mozilla.org/mozilla-central/rev/0ac1b18d489e
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•4 years ago
|
status-firefox62:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•