1449827 - Improve atom handling in nsTreeSanitizer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Nicholas Nethercote [inactive]]

Once bug 1449395 lands, we can convert all the &nsGkAtoms::foo occurrences in nsTreeSanitizer to nsGkAtoms::foo, as described in bug 1449787 comment 1.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449827 - Use `nsStaticAtom* const` instead of `nsStaticAtom** const` in nsTreeSanitizer.

Review commit: https://reviewboard.mozilla.org/r/232370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232370/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449827 - Introduce a typedef `AtomsTable` within nsTreeSanitizer.

This is much shorter than nsTHashtable<nsRefPtrHashKey<nsAtom>>, which is
repeated often.

Review commit: https://reviewboard.mozilla.org/r/232372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232372/

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449827 - Optimize static atom use in nsTreeSanitizer.

The various AtomsTables in nsTreeSanitizer only contain static atoms. Knowing
this, we can optimize things:

- They can contain raw nsStaticAtom pointers instead of refcounted nsAtom
  pointers.

- When looking up, we can/must first check if the atom we are looking for is
  static. If not, we know it can't be in the table. This is done by the new
  Contains() method.

This change also lets us add more `const` to various places that interact with
the tables.

Review commit: https://reviewboard.mozilla.org/r/232374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232374/

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 8963453 [details]
Bug 1449827 - Use `nsStaticAtom* const` instead of `nsStaticAtom** const` in nsTreeSanitizer.

https://reviewboard.mozilla.org/r/232370/#review237800

Wow. It looks like we're getting close to making interned HTML element and attribute names in the parser POD! Thanks.

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8963454 [details]
Bug 1449827 - Introduce a typedef `AtomsTable` within nsTreeSanitizer.

https://reviewboard.mozilla.org/r/232372/#review237802

Comment 6

[Henri Sivonen (:hsivonen)]

Comment on attachment 8963455 [details]
Bug 1449827 - Optimize static atom use in nsTreeSanitizer.

https://reviewboard.mozilla.org/r/232374/#review237804

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ad039952ae647a8d01167c6d1ca35883e96a477
Bug 1449827 - Use `nsStaticAtom* const` instead of `nsStaticAtom** const` in nsTreeSanitizer. r=hsivonen

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e54be07d824fe3c4a257d316ee85eee4f653f83
Bug 1449827 - Introduce a typedef `AtomsTable` within nsTreeSanitizer. r=hsivonen

https://hg.mozilla.org/integration/mozilla-inbound/rev/db3a89f85df2edd667a9503cc148e4e0721b3482
Bug 1449827 - Optimize static atom use in nsTreeSanitizer. r=hsivonen

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6ad039952ae6
https://hg.mozilla.org/mozilla-central/rev/4e54be07d824
https://hg.mozilla.org/mozilla-central/rev/db3a89f85df2