1449834 - Do not use Skia Assembly on x64 MinGW Build

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P5)

Description

[Tom Ritter [:tjr]]

In Bug 1364560 we fixed the Skia Build for MinGW which included not using the jumper assembly. It turns out that didn't quite work - there seems not to have been any jumper assembly for x86, so now that we're doing x64 we tried to use the assembly (and failed.)

We need to actually be sure not to use that assembly. Lots of errors like this

> [task 2018-03-28T16:33:03.657Z] 16:33:03     INFO -  /builds/worker/workspace/build/src/gfx/skia/skia/src/jumper/SkJumper.cpp:250: undefined reference to `_sk_hsl_to_rgb_avx'

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1449834 Define SK_JUMPER_USE_ASSEMBLY as 0, not False

When defined as 'False', we get -USK_JUMPER_USE_ASSEMBLY. When it's
undefined, it will be defined as 1.  What we actually need is
-DSK_JUMPER_USE_ASSEMBLY=0

Review commit: https://reviewboard.mozilla.org/r/232382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232382/

Comment 2

[Lee Salzman [:lsalzman]]

Comment on attachment 8963457 [details]
Bug 1449834 Define SK_JUMPER_USE_ASSEMBLY as 0, not False

https://reviewboard.mozilla.org/r/232382/#review237792

This is already fixed in beta and nightly as part of the Skia m66 update. The only build that should even hypothetically be affected by this anymore is release? If that is the case, backporting this is okay, I suppose.

Comment 3

[Tom Ritter [:tjr]]

Thanks!  I am indeed behind tree because of the --disable-stylo removal. I am considering trying to get this backported to esr60 though.