1449883 - Improve static atom handling in dom/svg/

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Nicholas Nethercote [inactive]]

Once bug 1449395 lands, we can convert all the &nsGkAtoms::foo occurrences in dom/svg/ to nsGkAtoms::foo, as described in bug 1449787 comment 1.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h.

The patch also const-ifies a bunch of nearby fields.

Review commit: https://reviewboard.mozilla.org/r/232480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232480/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping.

Review commit: https://reviewboard.mozilla.org/r/232482/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232482/

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests.

Review commit: https://reviewboard.mozilla.org/r/232484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232484/

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449883 - Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files.

The patch also removes some conditional tests involving unitMap[i] that are
now redundant due to preceding null tests against unitAtom.

Review commit: https://reviewboard.mozilla.org/r/233226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233226/

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8963537 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232480/diff/1-2/

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 8963538 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232482/diff/1-2/

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 8963539 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232484/diff/1-2/

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 8963537 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h.

https://reviewboard.mozilla.org/r/232480/#review240072

Lovely. :)

Comment 9

[Jonathan Watt [:jwatt]]

Comment on attachment 8963538 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping.

https://reviewboard.mozilla.org/r/232482/#review240074

Comment 10

[Jonathan Watt [:jwatt]]

Comment on attachment 8963539 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests.

https://reviewboard.mozilla.org/r/232484/#review240076

Comment 11

[Jonathan Watt [:jwatt]]

Comment on attachment 8964487 [details]
Bug 1449883 - Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files.

https://reviewboard.mozilla.org/r/233226/#review240078

Comment 12

[Nicholas Nethercote [inactive]]

Bug 1449787 commit 2 explains the situation here. Basically, I can't land this without a bunch of follow-up changes because it'll increase the number of static constructors :(

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/649bc3951808
Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h. r=jwatt
https://hg.mozilla.org/integration/mozilla-inbound/rev/1921c53d6e43
Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping. r=jwatt
https://hg.mozilla.org/integration/mozilla-inbound/rev/983306b6c000
Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests. r=jwatt
https://hg.mozilla.org/integration/mozilla-inbound/rev/13bc5a1c4d04
Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files. r=jwatt

Comment 14

[Nicholas Nethercote [inactive]]

This may increase the number of static constructors, but bug 1449787 is ready to land and it will reduce them again.

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/649bc3951808
https://hg.mozilla.org/mozilla-central/rev/1921c53d6e43
https://hg.mozilla.org/mozilla-central/rev/983306b6c000
https://hg.mozilla.org/mozilla-central/rev/13bc5a1c4d04