Closed
Bug 1449883
Opened 2 years ago
Closed Last year
Improve static atom handling in dom/svg/
Categories
(Core :: SVG, enhancement, P3)
Core
SVG
P3
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: njn, Assigned: njn)
References
Details
Attachments
(4 files)
Once bug 1449395 lands, we can convert all the &nsGkAtoms::foo occurrences in dom/svg/ to nsGkAtoms::foo, as described in bug 1449787 comment 1.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 8•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8963537 [details] Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h. https://reviewboard.mozilla.org/r/232480/#review240072 Lovely. :)
Attachment #8963537 -
Flags: review?(jwatt) → review+
|
|
||
Comment 9•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8963538 [details] Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping. https://reviewboard.mozilla.org/r/232482/#review240074
Attachment #8963538 -
Flags: review?(jwatt) → review+
|
|
||
Comment 10•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8963539 [details] Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests. https://reviewboard.mozilla.org/r/232484/#review240076
Attachment #8963539 -
Flags: review?(jwatt) → review+
|
|
||
Comment 11•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8964487 [details] Bug 1449883 - Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files. https://reviewboard.mozilla.org/r/233226/#review240078
Attachment #8964487 -
Flags: review?(jwatt) → review+
|
Assignee | |
Comment 12•2 years ago
|
||
Bug 1449787 commit 2 explains the situation here. Basically, I can't land this without a bunch of follow-up changes because it'll increase the number of static constructors :(
|
||
Updated•2 years ago
|
Priority: -- → P3
|
||
Comment 13•Last year
|
||
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/649bc3951808 Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/1921c53d6e43 Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/983306b6c000 Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/13bc5a1c4d04 Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files. r=jwatt
|
|
Assignee | |
Comment 14•Last year
|
||
This may increase the number of static constructors, but bug 1449787 is ready to land and it will reduce them again.
|
||
Comment 15•Last year
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/649bc3951808 https://hg.mozilla.org/mozilla-central/rev/1921c53d6e43 https://hg.mozilla.org/mozilla-central/rev/983306b6c000 https://hg.mozilla.org/mozilla-central/rev/13bc5a1c4d04
Status: ASSIGNED → RESOLVED
Closed: Last year
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•Last year
|
status-firefox62:
--- → wontfix
status-firefox63:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•