Closed Bug 1449883 Opened 2 years ago Closed Last year

Improve static atom handling in dom/svg/

Categories

(Core :: SVG, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(4 files)

Once bug 1449395 lands, we can convert all the &nsGkAtoms::foo occurrences in dom/svg/ to nsGkAtoms::foo, as described in bug 1449787 comment 1.
Comment on attachment 8963537 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h.

https://reviewboard.mozilla.org/r/232480/#review240072

Lovely. :)
Attachment #8963537 - Flags: review?(jwatt) → review+
Comment on attachment 8963538 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping.

https://reviewboard.mozilla.org/r/232482/#review240074
Attachment #8963538 - Flags: review?(jwatt) → review+
Comment on attachment 8963539 [details]
Bug 1449883 - Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests.

https://reviewboard.mozilla.org/r/232484/#review240076
Attachment #8963539 - Flags: review?(jwatt) → review+
Comment on attachment 8964487 [details]
Bug 1449883 - Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files.

https://reviewboard.mozilla.org/r/233226/#review240078
Attachment #8964487 - Flags: review?(jwatt) → review+
Bug 1449787 commit 2 explains the situation here. Basically, I can't land this without a bunch of follow-up changes because it'll increase the number of static constructors :(
Priority: -- → P3
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/649bc3951808
Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGElement.h. r=jwatt
https://hg.mozilla.org/integration/mozilla-inbound/rev/1921c53d6e43
Use `nsStaticAtom* const` instead of `nsStaticAtom**` in nsSVGEnumMapping. r=jwatt
https://hg.mozilla.org/integration/mozilla-inbound/rev/983306b6c000
Use `nsStaticAtom* const` instead of `nsStaticAtom**` in SVGTests. r=jwatt
https://hg.mozilla.org/integration/mozilla-inbound/rev/13bc5a1c4d04
Use `const nsStaticAtom* const` instead of `nsStaticAtom**` in some SVG .cpp files. r=jwatt
This may increase the number of static constructors, but bug 1449787 is ready to land and it will reduce them again.
You need to log in before you can comment on or make changes to this bug.