Closed Bug 1449999 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 10242 - Revert "bluetooth: FakeBluetoothChooser impl."

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 10242 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10242
Details from upstream follow.

François Doray <fdoray@chromium.org> wrote:
>  Revert "bluetooth: FakeBluetoothChooser impl."
>  
>  This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd.
>  
>  Reason for revert: https://crbug.com/824704
>  
>  These tests are failing:
>  
>  external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html
>  external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
>  external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
>  external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
>  external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html
>  
>  Original change's description:
>  > bluetooth: FakeBluetoothChooser impl.
>  > 
>  > Implements the interfaces that FakeBluetoothChooser overrides. The
>  > mojom::FakeBluetoothChooser overrides are implemented by running
>  > |event_handler_| with the appropriate arguments. The BluetoothChooser
>  > overrides do nothing at the moment, since the base class is only meant
>  > to update the chooser user interface.
>  > 
>  > This change also begins to partially convert a Bluetooth chooser test to test
>  > the interface and deletes the temporary tests that were created to test this
>  > API.
>  > 
>  > This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
>  > reverted the original change. The original change caused the
>  > new-scan-device-added.html test to fail because of a Mojo validation error
>  > resulting from not updating the
>  > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
>  > file needed by the test.
>  > 
>  > Bug: 719827, 719826, 824704, 826787
>  > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
>  > Reviewed-on: https://chromium-review.googlesource.com/985195
>  > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
>  > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
>  > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#546729}
>  
>  TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org
>  
>  Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 719827, 719826, 824704, 826787
>  Reviewed-on: https://chromium-review.googlesource.com/986592
>  Reviewed-by: François Doray <fdoray@chromium.org>
>  Commit-Queue: François Doray <fdoray@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#546851}
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9ec8ae030be
[wpt PR 10242] - Revert "bluetooth: FakeBluetoothChooser impl.", a=testonly
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.