1450125 - The "Add Search Engine" page action button doesn't have a plus-sign (+) badge when it's in the urlbar/address bar/location bar

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, enhancement, P5)

Description

[Drew Willcoxon :adw]

In the page action panel, the "Add Search Engine" action's icon is the page's favicon with a plus-sign (+) badge.  But if you add the action to the urlbar, it's only the favicon, no badge.

The reason is that the button in the panel is a toolbarbutton.badged-button, but the button in the urlbar is only an <image>.  I don't think <image>s support badges, but tbh I'm not sure.  It's probably possible to make it a toolbarbutton because as proof by example there's at least one toolbarbutton in the urlbar already, #urlbar-zoom-button.  But it would require modifying BrowserPageActions because currently it always creates <image>s for buttons in the urlbar.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Proton is removing this page-action button, so we can close the bug.

Comment 2

[Maverick]

Hi Marco,

I don't know if i'm getting this right - how will users add search engines then? As an addon?
Or am i missing something? Can you please give a glimpse of what's cooking (if you have the time)?

Thanks

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we move the option elsewhere in the urlbar, I'm working on that patch. No worries.

Comment 4

[Maverick]

Great =).

Thank you :)