The "Add Search Engine" page action button doesn't have a plus-sign (+) badge when it's in the urlbar/address bar/location bar

NEW
Unassigned

Status

()

enhancement
P5
normal
Last year
3 months ago

People

(Reporter: adw, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 affected)

Details

(Whiteboard: [fxsearch])

Reporter

Description

Last year
In the page action panel, the "Add Search Engine" action's icon is the page's favicon with a plus-sign (+) badge.  But if you add the action to the urlbar, it's only the favicon, no badge.

The reason is that the button in the panel is a toolbarbutton.badged-button, but the button in the urlbar is only an <image>.  I don't think <image>s support badges, but tbh I'm not sure.  It's probably possible to make it a toolbarbutton because as proof by example there's at least one toolbarbutton in the urlbar already, #urlbar-zoom-button.  But it would require modifying BrowserPageActions because currently it always creates <image>s for buttons in the urlbar.
Reporter

Updated

Last year
See Also: → 1449947
You need to log in before you can comment on or make changes to this bug.