1450170 - Add a Nightly-only observer notification that fires every time a tab switch spinner is displayed

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

I'm hoping to use that along with this WebExtension:

https://github.com/mikeconley/spindoctor

To get a handle on where some of the new spinners in bug 1449662 are coming from.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed.

Review commit: https://reviewboard.mozilla.org/r/232712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232712/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8963847 [details]
Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed.

https://reviewboard.mozilla.org/r/232712/#review238148


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: browser/modules/AsyncTabSwitcher.jsm:1037
(Diff revision 1)
>      this.addMarker("AsyncTabSwitch:SpinnerShown");
>      Services.telemetry
>        .getHistogramById("FX_TAB_SWITCH_SPINNER_VISIBLE_TRIGGER")
>        .add(this._loadTimerClearedBy);
> +    if (AppConstants.NIGHTLY_BUILD) {
> +      Services.obs.notifyObservers(null, "tabswitch-spinner", null);

Error: Notifyobservers's third parameter can be omitted. [eslint: mozilla/no-useless-parameters]

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8963847 [details]
Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232712/diff/1-2/

Comment 4

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8963847 [details]
Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed.

https://reviewboard.mozilla.org/r/232712/#review238156

LGTM

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45ec22b83237
Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed. r=dthayer

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/45ec22b83237