Cookie is not synced across tabs

NEW
Assigned to

Status

()

Core
Networking: Cookies
P1
normal
21 days ago
4 hours ago

People

(Reporter: Takeshi Terada, Assigned: valentin)

Tracking

({regression})

59 Branch
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [necko-triaged])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

21 days ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180323154952

Steps to reproduce:

Firefox 59.0.2 on Windows7.
Cookie set in a tab is not immediately synced in another tab.

1. Open a tab A - navigate to http://ws9.me/firefox59cookie.html
2. Open a tab B - navigate to http://ws9.me/firefox59cookie.html
3. In tab A, press "Set cookie", then press "Show cookie". A cookie is set in tab A.
4. In tab B, press "Show cookie" button. Cookie is blank.


Actual results:

See above.


Expected results:

In step4 in tab B, cookie should not be empty.

OK: Chrome 56, IE11 and Firefox 56.0.2
NG: Firefox 59.0.2
(Reporter)

Comment 1

20 days ago
Created attachment 8963892 [details]
firefox59cookie.html

Comment 2

16 days ago
We are also having the same issue. Before upgrade everything was working fine. All of a sudden after upgrade we are facing many issues related to cookie syncing.


Please prioritize this issue and provide a quick solution or workaround if any.
I can reproduce this issue on my machine  	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

On nightly I followed Steps 1-4. I requires a page refresh before Step 4 to see the cookie from Step 3.

Google Chrome and Edge update dynamically.
Component: Untriaged → Preferences
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: Preferences → Networking: Cookies
Product: Firefox → Core
(Assignee)

Comment 4

15 days ago
This seems to be a regression caused by bug 1425031.
Blocks: 1425031
(Assignee)

Updated

15 days ago
Duplicate of this bug: 1450592
(Assignee)

Updated

14 days ago
Assignee: nobody → valentin.gosu
Keywords: regression
Priority: -- → P1
Whiteboard: [necko-triaged]
Comment hidden (mozreview-request)
(Assignee)

Updated

3 days ago
Attachment #8968351 - Flags: review?(ehsan)

Comment 7

a day ago
mozreview-review
Comment on attachment 8968351 [details]
Bug 1450199 - Cookie is not synced across tabs

https://reviewboard.mozilla.org/r/237032/#review243510

Thanks, looks great!

::: commit-message-6276e:6
(Diff revision 1)
> +Bug 1450199 - Cookie is not synced across tabs
> +
> +This patch reverts parts of changeset e87e706def11 (bug 1425031).
> +The problem in bug 1425031 was that when the content process set a cookie
> +a notification was sent to the parent process. This notification was then
> +forwarded to all the content processes, including the one it originatd from.

Nit: "originated"
Attachment #8968351 - Flags: review?(ehsan) → review+
Comment hidden (mozreview-request)

Comment 9

9 hours ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5f3b781af6a7
Cookie is not synced across tabs r=Ehsan
(Assignee)

Comment 10

4 hours ago
Comment on attachment 8968351 [details]
Bug 1450199 - Cookie is not synced across tabs

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1425031

[User impact if declined]:
Cookies changed in one tab are not visible to another tab if the two tabs don't share the same process.

[Is this code covered by automated tests?]:
It has some tests. I am working on a different test for this specific use case.

[Has the fix been verified in Nightly?]:
Just landed in nightly.

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes. See comment 0.

[List of other uplifts needed for the feature/fix]:
None.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
This change reverts bug 1425031 and reimplements it in a simpler way. The test for bug 1425031 still passes.

[String changes made/needed]:
None.
Attachment #8968351 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.