1450223 - Make _buildSelectionMetadata not use getPage/ItemAnnotationNames

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P2)

Description

[Marco Bonardo [:mak]]

It is apparently possible to avoid calls to GetItemAnnotatioNames and GetPageAnnotationNames here, and additionally remove the latter.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1450223 - Remove unnecessary synchronous annotation lookups from the places context menu.

Review commit: https://reviewboard.mozilla.org/r/233252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233252/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8964518 [details]
Bug 1450223 - Remove unnecessary synchronous annotation lookups from the places context menu.

https://reviewboard.mozilla.org/r/233252/#review239350

woho, this is awesome!

::: browser/components/places/content/placesContextMenu.inc.xul:128
(Diff revision 1)
>    <menuitem id="placesContext_reload"
>              command="placesCmd_reload"
>              label="&cmd.reloadLivebookmark.label;"
>              accesskey="&cmd.reloadLivebookmark.accesskey;"
>              closemenu="single"
> -            selection="livemark/feedURI"/>
> +            selection="isLivemark"/>

since we have livemarkChild, bookmark, folder, query... maybe this could just be "livemark"?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8964518 [details]
Bug 1450223 - Remove unnecessary synchronous annotation lookups from the places context menu.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233252/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffbab00395cb
Remove unnecessary synchronous annotation lookups from the places context menu. r=mak

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ffbab00395cb