Closed Bug 1450245 Opened 3 years ago Closed 3 years ago

When a query uri changes, its contents should live update

Categories

(Toolkit :: Places, enhancement, P1)

Product:
Toolkit
Component:
Places
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1450245 - When a query uri changes, its contents should live update.
59 bytes, text/x-review-board-request
standard8
: review+
Details 
Currently changing the uri of a query doesn't change both its mURI and mQuery/mOptions. This means renaming a tag updates the copied queries, but doesn't update their contents until next restart.
Whiteboard: [fxsearch]
Summary: When a query uri changes, queries should live update → When a query uri changes, its contents should live update
Comment on attachment 8963948 [details]
Bug 1450245 - When a query uri changes, its contents should live update.

https://reviewboard.mozilla.org/r/232778/#review238800

::: toolkit/components/places/tests/queries/test_query_uri_liveupdate.js:14
(Diff revision 2)
> +      { url: "http://tag2.moz.com/" },
> +      { url: "place:tag=tag1" },
> +    ]
> +  });
> +  PlacesUtils.tagging.tagURI(Services.io.newURI("http://tag1.moz.com/"), ["tag1"]);
> +  PlacesUtils.tagging.tagURI(Services.io.newURI("http://tag2.moz.com/"), ["tag2"]);

nit: could possibly use the tags parameter for insertTree objects to add the tag automatically.
Attachment #8963948 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b32e3d1b5d9f
When a query uri changes, its contents should live update. r=standard8
https://hg.mozilla.org/mozilla-central/rev/b32e3d1b5d9f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Duplicate of this bug: 503923
You need to log in before you can comment on or make changes to this bug.