1450245 - When a query uri changes, its contents should live update

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Marco Bonardo [:mak]]

Currently changing the uri of a query doesn't change both its mURI and mQuery/mOptions. This means renaming a tag updates the copied queries, but doesn't update their contents until next restart.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1450245 - When a query uri changes, its contents should live update.

Review commit: https://reviewboard.mozilla.org/r/232778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232778/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8963948 [details]
Bug 1450245 - When a query uri changes, its contents should live update.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232778/diff/1-2/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8963948 [details]
Bug 1450245 - When a query uri changes, its contents should live update.

https://reviewboard.mozilla.org/r/232778/#review238800

::: toolkit/components/places/tests/queries/test_query_uri_liveupdate.js:14
(Diff revision 2)
> +      { url: "http://tag2.moz.com/" },
> +      { url: "place:tag=tag1" },
> +    ]
> +  });
> +  PlacesUtils.tagging.tagURI(Services.io.newURI("http://tag1.moz.com/"), ["tag1"]);
> +  PlacesUtils.tagging.tagURI(Services.io.newURI("http://tag2.moz.com/"), ["tag2"]);

nit: could possibly use the tags parameter for insertTree objects to add the tag automatically.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8963948 [details]
Bug 1450245 - When a query uri changes, its contents should live update.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232778/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b32e3d1b5d9f
When a query uri changes, its contents should live update. r=standard8

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b32e3d1b5d9f