1450249 - blob-invalidation: Round the bounds

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1450249. blob-invalidation: Round the bounds.

This fixes a number of reftest failures.

Review commit: https://reviewboard.mozilla.org/r/232770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232770/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8963932 [details]
Bug 1450249. blob-invalidation: Round the bounds.

https://reviewboard.mozilla.org/r/232770/#review238480

::: gfx/layers/wr/WebRenderCommandBuilder.cpp:543
(Diff revision 1)
> +    LayoutDeviceIntPoint offset = RoundedToInt(bounds.TopLeft());
> +    bounds = LayoutDeviceRect(offset, LayoutDeviceSize(RoundedToInt(bounds).Size()));

How is this different from
bounds = LayoutDeviceRect(RoundedToInt(bounds));
?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

The rounding of Rectangles is different https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#474

The rectangle rounding might be more correct, but I'd like to match the existing code for now.

Comment 5

[Markus Stange [:mstange]]

I'm not sure I understand. Both of these round the edges. Can you give me an example where the two would be different?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

I misread the original code as RoundedToInt(bounds.Size()))

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963932 [details]
Bug 1450249. blob-invalidation: Round the bounds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232770/diff/1-2/

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8963932 [details]
Bug 1450249. blob-invalidation: Round the bounds.

https://reviewboard.mozilla.org/r/232770/#review239010

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/763909764666
blob-invalidation: Round the bounds. r=mstange

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/763909764666