Closed Bug 1450257 Opened 2 years ago Closed 2 years ago

missing LLVM_CONFIG in mozconfig

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file, 2 obsolete files)

checking for the Leanplum SDK key... no
checking for the Pocket API key... no
checking for llvm-config... not found
ERROR: Could not find LLVM/Clang installation for compiling stylo build-time
bindgen.  Please specify the 'LLVM_CONFIG' environment variable
(recommended), pass the '--with-libclang-path' and '--with-clang-path'
options to configure, or put 'llvm-config' in your PATH.  Altering your
PATH may expose 'clang' as well, potentially altering your compiler,
which may not be what you intended.
*** Fix above errors and then restart with\
               "make -f client.mk build"
make[1]: *** [configure] Error 1
make[1]: Leaving directory `/builds/slave/c-cen-t-lnx/build'
make: *** [/builds/slave/c-cen-t-lnx/build/objdir/Makefile] Error 2
DEBUG: shell: unmounting all filesystems
Attached patch [mozconfigs] proposed change (obsolete) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8964232 - Flags: review?(frgrahl)
Comment on attachment 8964232 [details] [diff] [review]
[mozconfigs] proposed change

suite/config/mozconfigs/macosx64/nightly includes stylo. The other macOS configs not. Is this right. The include also uses double quotes. The others are unquoted. For consistency I would either leave the quotes out here if not needed.

Can we change the toplevel build without informing TB?
Attachment #8964232 - Flags: review?(frgrahl) → review+
Attached patch [mozconfigs] proposed patch (v3) (obsolete) — Splinter Review
removed all the quotes and fixed win64's release-l10 mozconfig filename.
Attachment #8964232 - Attachment is obsolete: true
Attachment #8964462 - Flags: review?(frgrahl)
(In reply to Frank-Rainer Grahl (:frg) from comment #2)
> Comment on attachment 8964232 [details] [diff] [review]
> [mozconfigs] proposed change
> 
> suite/config/mozconfigs/macosx64/nightly includes stylo. The other macOS
> configs not. Is this right. The include also uses double quotes. The others
> are unquoted. For consistency I would either leave the quotes out here if
> not needed.
> 
> Can we change the toplevel build without informing TB?

also.. talked to :tomprince on irc..  TB doesn't use c-c/build/mozconfig.stylo.

So yes.. we can. :)
Comment on attachment 8964462 [details] [diff] [review]
[mozconfigs] proposed patch (v3)

suite/config/mozconfigs/macosx64/release is still missing the stylo include otherwise looks good.
Attachment #8964462 - Flags: review?(frgrahl) → review+
(In reply to Frank-Rainer Grahl (:frg) from comment #5)
> Comment on attachment 8964462 [details] [diff] [review]
> [mozconfigs] proposed patch (v3)
> 
> suite/config/mozconfigs/macosx64/release is still missing the stylo include
> otherwise looks good.

The reason is because when it includes build/macosx/mozconfig.common, the mozconfig.stylo 
is also included.
(In reply to Edmund Wong (:ewong) from comment #6)
> (In reply to Frank-Rainer Grahl (:frg) from comment #5)
> > Comment on attachment 8964462 [details] [diff] [review]
> > [mozconfigs] proposed patch (v3)
> > 
> > suite/config/mozconfigs/macosx64/release is still missing the stylo include
> > otherwise looks good.
> 
> The reason is because when it includes build/macosx/mozconfig.common, the
> mozconfig.stylo 
> is also included.

However, that said, it uses $topsrcdir, which is potentially an issue.. so yeah. will update
the patch.
I changed the calls to local-mozconfig.common instead of calling the
build/macosx/mozconfig.common because it calls everything with $topsrcdir.

is this ok?
Attachment #8964462 - Attachment is obsolete: true
Flags: needinfo?(frgrahl)
Attachment #8966096 - Flags: review+
> is this ok?

discussed via irc all clear.
Flags: needinfo?(frgrahl)
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/fb3ed35de114
Set LLVM_CONFIG in mozconfig.stylo and have platform mozconfigs read from this file again
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.