Closed Bug 1450311 Opened 6 years ago Closed 6 years ago

Value rearrangement breaks jsval.rs

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Unassigned)

References

Details

See bug 1447701 comment 8.  Not sure who's responsible for maintaining jsval.rs.
Flags: needinfo?(jwalden+bmo)
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05379c1bc4a5
Update jsval.rs's glue code for JS::Value::layout going away and its former members being renamed.  r=me on the dead-simple changes
Error messages in the tbpl log made clear what the failure was, the obvious fixes passed try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3939642177f67eff0a2193b3f1a49e898f21b728

so landed the fix self-reviewed.  (FWIW, my assumption was the Rust build was pre-existingly broken by the constexpr jsid thing, but I guess not.)
Flags: needinfo?(jwalden+bmo)
Jeff, thank you for fixing that!
https://hg.mozilla.org/mozilla-central/rev/05379c1bc4a5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.