Closed Bug 1450566 Opened 6 years ago Closed 6 years ago

Replace aboutSessionRestore-window-icon.png usage with window.svg

Categories

(Firefox :: Theme, enhancement)

Product:
Firefox
Component:
Theme
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: ntim, Assigned: manishkk)

References

(Blocks 2 open bugs)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Patch_Bug1450566
3.72 KB, patch
ntim
: review+
dao
: review+
Details | Diff | Splinter Review
Screenshot of patch
95.47 KB, image/png
Details 
To fix this bug:
- Replace "chrome://browser/skin/aboutSessionRestore-window-icon.png" with "chrome://browser/skin/window.svg" in browser/themes/shared/aboutSessionRestore.css and browser/themes/shared/aboutWelcomeBack.css

- Remove the 3 aboutSessionRestore-window-icon.png files

- Remove their remaining references: https://searchfox.org/mozilla-central/search?q=aboutSessionRestore-window-icon.png&case=false&regexp=false&path=
Blocks: png-cleanup
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1450566 — — Splinter Review 
Please review.
Attachment #8964200 - Flags: review?(ntim.bugs)
Attachment #8964200 - Flags: review?(dao+bmo)
Attached image Screenshot of patch — 

    
    

    
  
Comment on attachment 8964200 [details] [diff] [review]
Patch_Bug1450566

Review of attachment 8964200 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested this locally, and it works great! Thanks.

        Attachment #8964200 -
        Flags: review?(ntim.bugs) → review+

        Attachment #8964200 -
        Flags: review?(dao+bmo) → review+

    
    

    
  
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ad35a441785
Replace aboutSessionRestore-window-icon.png usage with window.svg. r=ntim,dao

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1ad35a441785
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox61:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: