Closed Bug 1450588 Opened Last year Closed Last year

Remove old bookmark animation code and images

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: ntim, Assigned: manishkk, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

This is code for the pre-photon bookmarks animation.

Files to remove:
browser/themes/shared/bookmarked-notification.inc.css
browser/themes/shared/places/bookmarks-notification-finish.png
browser/themes/shared/places/bookmarks-notification-finish@2x.png

Code to remove:
https://dxr.mozilla.org/mozilla-central/search?q=bookmarked-notification.inc.css&redirect=false

https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/jar.inc.mn#219,220

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#527-534
Mentor: ntim.bugs
Keywords: good-first-bug
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1450588 (obsolete) — Splinter Review
Please Review.

Thanks
Attachment #8964212 - Flags: review?(dao+bmo)
Attachment #8964212 - Attachment is obsolete: true
Attachment #8964212 - Flags: review?(dao+bmo)
Attachment #8964246 - Flags: review?(ntim.bugs)
Attachment #8964246 - Flags: review?(dao+bmo)
Comment on attachment 8964246 [details] [diff] [review]
Patch2_Bug1450588

Review of attachment 8964246 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Couldn't think of anything else to remove. Let's wait for dao's review :)
Attachment #8964246 - Flags: review?(ntim.bugs) → review+
Comment on attachment 8964246 [details] [diff] [review]
Patch2_Bug1450588

Thanks!
Attachment #8964246 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cf6e03f7f24
Remove old bookmark animation code and images. r=ntim,dao
https://hg.mozilla.org/mozilla-central/rev/5cf6e03f7f24
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.