Closed
Bug 1450588
Opened 6 years ago
Closed 6 years ago
Remove old bookmark animation code and images
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ntim, Assigned: manishkk, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
6.57 KB,
patch
|
dao
:
review+
ntim
:
review+
|
Details | Diff | Splinter Review |
This is code for the pre-photon bookmarks animation. Files to remove: browser/themes/shared/bookmarked-notification.inc.css browser/themes/shared/places/bookmarks-notification-finish.png browser/themes/shared/places/bookmarks-notification-finish@2x.png Code to remove: https://dxr.mozilla.org/mozilla-central/search?q=bookmarked-notification.inc.css&redirect=false https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/jar.inc.mn#219,220 https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#527-534
Reporter | ||
Updated•6 years ago
|
Mentor: ntim.bugs
Keywords: good-first-bug
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
Assignee | ||
Comment 1•6 years ago
|
||
Please Review. Thanks
Attachment #8964212 -
Flags: review?(dao+bmo)
Reporter | ||
Comment 2•6 years ago
|
||
I believe this also needs to be removed: https://searchfox.org/mozilla-central/source/browser/base/content/browser-places.js#1254-1263
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8964212 -
Attachment is obsolete: true
Attachment #8964212 -
Flags: review?(dao+bmo)
Attachment #8964246 -
Flags: review?(ntim.bugs)
Attachment #8964246 -
Flags: review?(dao+bmo)
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8964246 [details] [diff] [review] Patch2_Bug1450588 Review of attachment 8964246 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me. Couldn't think of anything else to remove. Let's wait for dao's review :)
Attachment #8964246 -
Flags: review?(ntim.bugs) → review+
Comment 5•6 years ago
|
||
Comment on attachment 8964246 [details] [diff] [review] Patch2_Bug1450588 Thanks!
Attachment #8964246 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5cf6e03f7f24 Remove old bookmark animation code and images. r=ntim,dao
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5cf6e03f7f24
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•