Remove toolkit/themes/{windows|osx}/global/icons/tabprompts-bgtexture.png

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ntim, Assigned: manishkk, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

a year ago
I don't think those make a significant visual difference, and even if they did, I'm not sure we'd still want it today.

Files to remove:

toolkit/themes/osx/global/icons/tabprompts-bgtexture.png
toolkit/themes/windows/global/icons/tabprompts-bgtexture.png

Lines to remove:

https://dxr.mozilla.org/mozilla-central/search?q=tabprompts-bgtexture+-path%3Aobj&redirect=false
Reporter

Updated

a year ago
Component: Theme → Themes
Product: Firefox → Toolkit
Assignee

Updated

a year ago
Assignee: nobody → 1991manish.kumar
Assignee

Comment 1

a year ago
Please review. 
Thanks
Attachment #8964219 - Flags: review?(dao+bmo)
Attachment #8964219 - Flags: ui-review?(shorlander)
Attachment #8964219 - Flags: review?(dolske)
Attachment #8964219 - Flags: review?(dao+bmo)
Comment on attachment 8964219 [details] [diff] [review]
Patch_Bug1450593

Let's have Stephen weigh in before review.
Attachment #8964219 - Flags: review?(dolske)
Those are safe to remove. We aren't using the noise texture any more. Thank you!
Reporter

Updated

a year ago
Attachment #8964219 - Flags: review?(dolske)
Attachment #8964219 - Flags: review?(dao+bmo)
Attachment #8964219 - Flags: review?(dolske)
Attachment #8964219 - Flags: review?(dao+bmo)
Attachment #8964219 - Flags: review+

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3cb5a80d7c
Remove toolkit/themes/{windows|osx}/global/icons/tabprompts-bgtexture.png. r=Dao, ui-r=shorlander
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b3cb5a80d7c
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.