Closed
Bug 1450593
Opened 6 years ago
Closed 6 years ago
Remove toolkit/themes/{windows|osx}/global/icons/tabprompts-bgtexture.png
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: ntim, Assigned: manishkk, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
3.56 KB,
patch
|
dao
:
review+
shorlander
:
ui-review+
|
Details | Diff | Splinter Review |
I don't think those make a significant visual difference, and even if they did, I'm not sure we'd still want it today. Files to remove: toolkit/themes/osx/global/icons/tabprompts-bgtexture.png toolkit/themes/windows/global/icons/tabprompts-bgtexture.png Lines to remove: https://dxr.mozilla.org/mozilla-central/search?q=tabprompts-bgtexture+-path%3Aobj&redirect=false
|
Reporter | |
Updated•6 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
|
Assignee | |
Comment 1•6 years ago
|
||
Please review. Thanks
Attachment #8964219 -
Flags: review?(dao+bmo)
|
||
Updated•6 years ago
|
Attachment #8964219 -
Flags: ui-review?(shorlander)
Attachment #8964219 -
Flags: review?(dolske)
Attachment #8964219 -
Flags: review?(dao+bmo)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8964219 [details] [diff] [review] Patch_Bug1450593 Let's have Stephen weigh in before review.
Attachment #8964219 -
Flags: review?(dolske)
|
||
Comment 3•6 years ago
|
||
Those are safe to remove. We aren't using the noise texture any more. Thank you!
|
|
||
Updated•6 years ago
|
Attachment #8964219 -
Flags: ui-review?(shorlander) → ui-review+
|
|
Reporter | |
Updated•6 years ago
|
Attachment #8964219 -
Flags: review?(dolske)
Attachment #8964219 -
Flags: review?(dao+bmo)
|
|
||
Updated•6 years ago
|
Attachment #8964219 -
Flags: review?(dolske)
Attachment #8964219 -
Flags: review?(dao+bmo)
Attachment #8964219 -
Flags: review+
|
|
||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3cb5a80d7c Remove toolkit/themes/{windows|osx}/global/icons/tabprompts-bgtexture.png. r=Dao, ui-r=shorlander
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1b3cb5a80d7c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•