Closed Bug 1450593 Opened 3 years ago Closed 3 years ago

Remove toolkit/themes/{windows|osx}/global/icons/tabprompts-bgtexture.png

Categories

(Toolkit :: Themes, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: ntim, Assigned: manishkk, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

I don't think those make a significant visual difference, and even if they did, I'm not sure we'd still want it today.

Files to remove:

toolkit/themes/osx/global/icons/tabprompts-bgtexture.png
toolkit/themes/windows/global/icons/tabprompts-bgtexture.png

Lines to remove:

https://dxr.mozilla.org/mozilla-central/search?q=tabprompts-bgtexture+-path%3Aobj&redirect=false
Component: Theme → Themes
Product: Firefox → Toolkit
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1450593Splinter Review
Please review. 
Thanks
Attachment #8964219 - Flags: review?(dao+bmo)
Attachment #8964219 - Flags: ui-review?(shorlander)
Attachment #8964219 - Flags: review?(dolske)
Attachment #8964219 - Flags: review?(dao+bmo)
Comment on attachment 8964219 [details] [diff] [review]
Patch_Bug1450593

Let's have Stephen weigh in before review.
Attachment #8964219 - Flags: review?(dolske)
Those are safe to remove. We aren't using the noise texture any more. Thank you!
Attachment #8964219 - Flags: review?(dolske)
Attachment #8964219 - Flags: review?(dao+bmo)
Attachment #8964219 - Flags: review?(dolske)
Attachment #8964219 - Flags: review?(dao+bmo)
Attachment #8964219 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3cb5a80d7c
Remove toolkit/themes/{windows|osx}/global/icons/tabprompts-bgtexture.png. r=Dao, ui-r=shorlander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1b3cb5a80d7c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.