Closed
Bug 1450612
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10265 - Set SkipServiceWorker flag for synchronous loads from the main thread.
Categories
(Core :: DOM: Service Workers, enhancement, P4)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10265 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10265 Details from upstream follow. Tsuyoshi Horo <horo@chromium.org> wrote: > Set SkipServiceWorker flag for synchronous loads from the main thread. > > Before 5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c, synchronous XHR on worker > was handled by service workers. It is because the |is_sync_load| was false > when the sync request is from worker thread. But after the CL, the > |is_sync_load| flag for the sync request from worker became true, so the request > will not go to the service worker. > > This CL will fix this by > - Set the SkipServiceWorker flag for synchronous loads from the main thread > in the renderer process. (FetchParameters.cpp) > - Don't set skip_service_worker even if is_sync_load is true in the browser > process. (resource_dispatcher_host_impl.cc) > > Bug: 706331,827473 > Change-Id: I186bc97f3f8d298e0a04942d0ec4b708b3022cc1 > > Reviewed-on: https://chromium-review.googlesource.com/989376 > WPT-Export-Revision: 005182acdf1bb4009f1cbcb0b3a76a450b41344c
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=189b3e68dbddfb7bde8d15f5b6f1e3bf9a84f075
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7716edece195dcda4f4f434f968434c940344227
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9c61563fa23d [wpt PR 10265] - Set SkipServiceWorker flag for synchronous loads from the main thread., a=testonly
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9c61563fa23d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•