1450721 - Remove not useful special-case in nsCSSFrameConstructor.

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1450721: Remove special-case in nsCSSFrameConstructor.

We don't extend these elements, and I don't feel bad making that code depend on
the UA rule at:

  https://searchfox.org/mozilla-central/rev/b80994a43e5d92c2f79160ece176127eed85dcc9/toolkit/content/xul.css#63

If we don't create frames for these, we bail out due to the lack of an insertion
point. If we do, well, things are buggy already.

Review commit: https://reviewboard.mozilla.org/r/233046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233046/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8964319 [details]
Bug 1450721: Remove special-case in nsCSSFrameConstructor.

https://reviewboard.mozilla.org/r/233046/#review238542

::: commit-message-98edf:6
(Diff revision 1)
> +Bug 1450721: Remove special-case in nsCSSFrameConstructor. r?bz
> +
> +We don't extend these elements, and I don't feel bad making that code depend on
> +the UA rule at:
> +
> +  https://searchfox.org/mozilla-central/rev/b80994a43e5d92c2f79160ece176127eed85dcc9/toolkit/content/xul.css#63

I don't know that we trust searchfox urls to be stable, and the fact that it uses different revision ids from mozilla-central is a bit of a problem with mapping from that to code in mozilla-central....  Maybe better to just say what hg rev, file, and line is involved?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #2)
> Comment on attachment 8964319 [details]
> Bug 1450721: Remove special-case in nsCSSFrameConstructor.
> 
> https://reviewboard.mozilla.org/r/233046/#review238542
> 
> ::: commit-message-98edf:6
> (Diff revision 1)
> > +Bug 1450721: Remove special-case in nsCSSFrameConstructor. r?bz
> > +
> > +We don't extend these elements, and I don't feel bad making that code depend on
> > +the UA rule at:
> > +
> > +  https://searchfox.org/mozilla-central/rev/b80994a43e5d92c2f79160ece176127eed85dcc9/toolkit/content/xul.css#63
> 
> I don't know that we trust searchfox urls to be stable, and the fact that it
> uses different revision ids from mozilla-central is a bit of a problem with
> mapping from that to code in mozilla-central....  Maybe better to just say
> what hg rev, file, and line is involved?

FWIW searchfox urls should be stable, they just use git revisions instead of hg, which have a 1-to-1 mapping. But yeah, I'll link to hg.m.o.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I guess I can just rebase bug 1450717 on top of this instead of the other way around.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b252b846aba
Remove special-case in nsCSSFrameConstructor. r=bz

Comment 6

[Boris Zbarsky [:bzbarsky]]

> FWIW searchfox urls should be stable

Until we kill it like we did mxr...  I'm talking about the long term here.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2b252b846aba