Closed
Bug 1450721
Opened 6 years ago
Closed 6 years ago
Remove not useful special-case in nsCSSFrameConstructor.
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
![]() |
||
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8964319 [details] Bug 1450721: Remove special-case in nsCSSFrameConstructor. https://reviewboard.mozilla.org/r/233046/#review238542 ::: commit-message-98edf:6 (Diff revision 1) > +Bug 1450721: Remove special-case in nsCSSFrameConstructor. r?bz > + > +We don't extend these elements, and I don't feel bad making that code depend on > +the UA rule at: > + > + https://searchfox.org/mozilla-central/rev/b80994a43e5d92c2f79160ece176127eed85dcc9/toolkit/content/xul.css#63 I don't know that we trust searchfox urls to be stable, and the fact that it uses different revision ids from mozilla-central is a bit of a problem with mapping from that to code in mozilla-central.... Maybe better to just say what hg rev, file, and line is involved?
Attachment #8964319 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #2) > Comment on attachment 8964319 [details] > Bug 1450721: Remove special-case in nsCSSFrameConstructor. > > https://reviewboard.mozilla.org/r/233046/#review238542 > > ::: commit-message-98edf:6 > (Diff revision 1) > > +Bug 1450721: Remove special-case in nsCSSFrameConstructor. r?bz > > + > > +We don't extend these elements, and I don't feel bad making that code depend on > > +the UA rule at: > > + > > + https://searchfox.org/mozilla-central/rev/b80994a43e5d92c2f79160ece176127eed85dcc9/toolkit/content/xul.css#63 > > I don't know that we trust searchfox urls to be stable, and the fact that it > uses different revision ids from mozilla-central is a bit of a problem with > mapping from that to code in mozilla-central.... Maybe better to just say > what hg rev, file, and line is involved? FWIW searchfox urls should be stable, they just use git revisions instead of hg, which have a 1-to-1 mapping. But yeah, I'll link to hg.m.o.
Assignee | ||
Comment 4•6 years ago
|
||
I guess I can just rebase bug 1450717 on top of this instead of the other way around.
No longer depends on: 1450717
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b252b846aba Remove special-case in nsCSSFrameConstructor. r=bz
![]() |
||
Comment 6•6 years ago
|
||
> FWIW searchfox urls should be stable
Until we kill it like we did mxr... I'm talking about the long term here.
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2b252b846aba
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Blocks: war-on-xbl
Updated•4 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•