1450738 - Assertion failure: !GetComputedStyleInMap(aMap, aContent) (Already have an entry for aContent), at /builds/worker/workspace/build/src/layout/base/nsFrameManager.cpp:198

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P2)

Description

[Jason Kratzer [:jkratzer]]

Attachment: trigger.html

Testcase found while fuzzing mozilla-central rev c44f60c43432.

rax = 0x0000000000000000   rdx = 0x0000000000000000
rcx = 0x00007fd0f6b5f2dd   rbx = 0x00007fd0da382bd0
rsi = 0x00007fd0f6e2e770   rdi = 0x00007fd0f6e2d540
rbp = 0x00007ffd5cbcbdb0   rsp = 0x00007ffd5cbcbd90
r8 = 0x00007fd0f6e2e770    r9 = 0x00007fd0f7ef9740
r10 = 0x0000000000000039   r11 = 0x0000000000000000
r12 = 0x00007fd0d535a3a0   r13 = 0x00007fd0d533f608
r14 = 0x00007fd0d9e4f220   r15 = 0x00007fd0da382bd0
rip = 0x00007fd0e6e75ac5
OS|Linux|0.0.0 Linux 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 21:23:04 UTC 2018 x86_64
CPU|amd64|family 6 model 78 stepping 3|1
GPU|||
Crash|SIGSEGV|0x0|0
0|0|libxul.so|nsFrameManager::SetComputedStyleInMap|hg:hg.mozilla.org/mozilla-central:layout/base/nsFrameManager.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|197|0x18
0|1|libxul.so|nsCSSFrameConstructor::FrameConstructionItemList::Destroy|hg:hg.mozilla.org/mozilla-central:layout/base/nsCSSFrameConstructor.h:c44f60c43432d468639b5fe078420e60c13fd3de|1052|0xf
0|2|libxul.so|nsCSSFrameConstructor::AutoFrameConstructionItemList::~AutoFrameConstructionItemList|hg:hg.mozilla.org/mozilla-central:layout/base/nsCSSFrameConstructor.h:c44f60c43432d468639b5fe078420e60c13fd3de|1118|0x9
0|3|libxul.so|nsCSSFrameConstructor::ContentRangeInserted|hg:hg.mozilla.org/mozilla-central:layout/base/nsCSSFrameConstructor.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|7795|0xc
0|4|libxul.so|mozilla::RestyleManager::ProcessRestyledFrames|hg:hg.mozilla.org/mozilla-central:layout/base/RestyleManager.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|1399|0x15
0|5|libxul.so|mozilla::ServoRestyleManager::DoProcessPendingRestyles|hg:hg.mozilla.org/mozilla-central:layout/base/ServoRestyleManager.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|1183|0xb
0|6|libxul.so|mozilla::PresShell::DoFlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:layout/base/RestyleManagerInlines.h:c44f60c43432d468639b5fe078420e60c13fd3de|43|0x8
0|7|libxul.so|nsIDocument::FlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:layout/base/nsIPresShell.h:c44f60c43432d468639b5fe078420e60c13fd3de|592|0xc
0|8|libxul.so|nsIDocument::FlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|7427|0x7
0|9|libxul.so|nsDocLoader::DocLoaderIsEmpty|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|700|0x10
0|10|libxul.so|nsDocLoader::OnStopRequest|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|632|0x16
0|11|libxul.so|mozilla::net::nsLoadGroup::RemoveRequest|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsLoadGroup.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|629|0x1f
0|12|libxul.so|nsIDocument::DoUnblockOnload|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|8323|0x20
0|13|libxul.so|nsDocument::UnblockOnload|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|8245|0x5
0|14|libxul.so|nsIDocument::DispatchContentLoadedEvents|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|5311|0x11
0|15|libxul.so|mozilla::detail::RunnableMethodImpl<nsIDocument*, void (nsIDocument::*)(), true, (mozilla::RunnableKind)0u>::Run|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:c44f60c43432d468639b5fe078420e60c13fd3de|1164|0x13
0|16|libxul.so|mozilla::SchedulerGroup::Runnable::Run|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|415|0x1c
0|17|libxul.so|nsThread::ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|1096|0x15
0|18|libxul.so|NS_ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|519|0x11
0|19|libxul.so|mozilla::ipc::MessagePump::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|97|0xa
0|20|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:c44f60c43432d468639b5fe078420e60c13fd3de|326|0x17
0|21|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:c44f60c43432d468639b5fe078420e60c13fd3de|319|0x8
0|22|libxul.so|nsBaseAppShell::Run|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|157|0xd
0|23|libxul.so|XRE_RunAppShell|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|893|0x11
0|24|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|269|0x5
0|25|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:c44f60c43432d468639b5fe078420e60c13fd3de|326|0x17
0|26|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:c44f60c43432d468639b5fe078420e60c13fd3de|319|0x8
0|27|libxul.so|XRE_InitChildProcess|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|719|0x8
0|28|firefox|content_process_main|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|50|0x14
0|29|firefox|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:c44f60c43432d468639b5fe078420e60c13fd3de|280|0x11
0|30|libc-2.23.so||||0x20830
0|31|firefox|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:c44f60c43432d468639b5fe078420e60c13fd3de|164|0x5

Comment 1

[Andrew McCreight [:mccr8]]

Heycam, could you take a look at this? Is this a serious assertion or does not not matter much?

Comment 2

[Cameron McCormack (:heycam)]

The undisplayed style map code got removed in bug 1303605.  Jason, can you confirm that you don't run into any other assertions with current m-c?

Comment 3

[Jason Kratzer [:jkratzer]]

(In reply to Cameron McCormack (:heycam) from comment #2)
> The undisplayed style map code got removed in bug 1303605.  Jason, can you
> confirm that you don't run into any other assertions with current m-c?

I can confirm that no assertions are triggered on the latest m-c.

Comment 4

[Cameron McCormack (:heycam)]

Thanks for checking!