1450801 - Remove addons manager support for telemetry experiments

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments

Review commit: https://reviewboard.mozilla.org/r/233142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233142/

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments

Review commit: https://reviewboard.mozilla.org/r/233144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233144/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8964415 [details]
Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments

https://reviewboard.mozilla.org/r/233142/#review238592


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: toolkit/mozapps/extensions/content/extensions.js:310
(Diff revision 1)
>   * that the supposed browser chrome window is capable of opening a preferences
>   * pane.
>   *
>   * This may return null if we can't find the browser chrome window.
>   */
>  function getMainWindowWithPreferencesPane() {

Error: 'getmainwindowwithpreferencespane' is defined but never used. [eslint: no-unused-vars]

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8964415 [details]
Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233142/diff/1-2/

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8964416 [details]
Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233144/diff/1-2/

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8964415 [details]
Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments

https://reviewboard.mozilla.org/r/233142/#review238622

::: browser/app/profile/firefox.js:1517
(Diff revision 2)
>  pref("experiments.enabled", true);
>  pref("experiments.manifest.fetchIntervalSeconds", 86400);
>  pref("experiments.manifest.uri", "https://telemetry-experiment.cdn.mozilla.net/manifest/v1/firefox/%VERSION%/%CHANNEL%");

Shouldn't these go away, too?

::: testing/profiles/prefs_general.js:75
(Diff revision 2)
>  // Point the manifest at something local so we don't risk it hitting production
>  // data and installing experiments that may vary over time.
>  user_pref("experiments.manifest.uri", "http://%(server)s/experiments-dummy/manifest");

Shouldn't this go away?

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8964416 [details]
Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments

https://reviewboard.mozilla.org/r/233144/#review238626

\o/

Comment 8

[Andrew Swan [:aswan]]

Comment on attachment 8964415 [details]
Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments

https://reviewboard.mozilla.org/r/233142/#review238622

> Shouldn't these go away, too?

I believe these are still used by code in either browser/experiments or toolkit/telemetry -- that should get all cleaned up in bug 
1420908

> Shouldn't this go away?

ditto

Comment 9

[Andrew Swan [:aswan]]

Comment on attachment 8964416 [details]
Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233144/diff/2-3/

Comment 10

[Andrew Swan [:aswan]]

Comment on attachment 8964415 [details]
Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233142/diff/2-3/

Comment 11

[Andrew Swan [:aswan]]

Comment on attachment 8964416 [details]
Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233144/diff/3-4/

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b81ac6c5c2074e02b5b89a2de4d104abc3397e72
Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments. r=kmag

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e68f15bcb09229f722d0564426787c735cb9b5a
Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments. r=kmag

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b81ac6c5c207
https://hg.mozilla.org/mozilla-central/rev/9e68f15bcb09

Comment 14

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!