Closed
Bug 1450801
Opened 6 years ago
Closed 6 years ago
Remove addons manager support for telemetry experiments
Categories
(Toolkit :: Add-ons Manager, enhancement, P2)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: aswan, Assigned: aswan)
References
Details
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8964415 [details] Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments https://reviewboard.mozilla.org/r/233142/#review238592 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: toolkit/mozapps/extensions/content/extensions.js:310 (Diff revision 1) > * that the supposed browser chrome window is capable of opening a preferences > * pane. > * > * This may return null if we can't find the browser chrome window. > */ > function getMainWindowWithPreferencesPane() { Error: 'getmainwindowwithpreferencespane' is defined but never used. [eslint: no-unused-vars]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8964416 -
Flags: review?(kmaglione+bmo)
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8964415 [details] Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments https://reviewboard.mozilla.org/r/233142/#review238622 ::: browser/app/profile/firefox.js:1517 (Diff revision 2) > pref("experiments.enabled", true); > pref("experiments.manifest.fetchIntervalSeconds", 86400); > pref("experiments.manifest.uri", "https://telemetry-experiment.cdn.mozilla.net/manifest/v1/firefox/%VERSION%/%CHANNEL%"); Shouldn't these go away, too? ::: testing/profiles/prefs_general.js:75 (Diff revision 2) > // Point the manifest at something local so we don't risk it hitting production > // data and installing experiments that may vary over time. > user_pref("experiments.manifest.uri", "http://%(server)s/experiments-dummy/manifest"); Shouldn't this go away?
Attachment #8964415 -
Flags: review?(kmaglione+bmo) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8964416 [details] Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments https://reviewboard.mozilla.org/r/233144/#review238626 \o/
Attachment #8964416 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 8•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8964415 [details] Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments https://reviewboard.mozilla.org/r/233142/#review238622 > Shouldn't these go away, too? I believe these are still used by code in either browser/experiments or toolkit/telemetry -- that should get all cleaned up in bug 1420908 > Shouldn't this go away? ditto
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Priority: -- → P2
Comment 12•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b81ac6c5c2074e02b5b89a2de4d104abc3397e72 Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments. r=kmag https://hg.mozilla.org/integration/mozilla-inbound/rev/9e68f15bcb09229f722d0564426787c735cb9b5a Bug 1450801 Part 2: Remove AddonManager support for telemetry experiments. r=kmag
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b81ac6c5c207 https://hg.mozilla.org/mozilla-central/rev/9e68f15bcb09
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 14•6 years ago
|
||
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag. Thanks!
Flags: needinfo?(aswan)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(aswan) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•