1450834 - Get rid of AddonManagerTesting.jsm

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Kris Maglione [:kmag]]

It's silly. It's mostly only used by experiments tests, and when they're gone, the rest can be updated to use plain AOM APIs or AddonTestUtils.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1450834: Remove AddonManagerTesting.jsm for it is monumentally silly.

Review commit: https://reviewboard.mozilla.org/r/236780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236780/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8968101 [details]
Bug 1450834: Remove AddonManagerTesting.jsm for it is monumentally silly.

https://reviewboard.mozilla.org/r/236780/#review243504

::: toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js:1210
(Diff revision 1)
> +  dump(`DICTIONARY ADDON ${dictionaryAddon}\n`);
> +  dump(`           ADDON ${uneval(dictionaryAddon)}\n`);

remove before landing

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/894d7e5286e1cd81586232dcd18c2a3300f000d5
Bug 1450834: Remove AddonManagerTesting.jsm for it is monumentally silly. r=aswan

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/894d7e5286e1