1450904 - FontFace::mDescriptors should hold just descriptors data rather than @font-face rule

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

After bug 1449087, FontFace::mDescriptors will be holding a RawServoFontFaceRule, while we should be able to have it just hold the descriptors data.

We should probably have a new struct in Servo side for just the descriptors, something like FontFaceData, and have FontFaceRule contain it. Then we can make FontFace::mDescriptors use a UniquePtr to hold that data.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Also, with this, we can move the definition of FontFaceRule from style::font_face into style::stylesheets::font_face_rule, and leave the FontFaceData in style::font_face. That would also make things clearer.