1450977 - Remove devtools/server/actors/object/long-string.js

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1449188, we plan to move the longString actor used by the object actor in its own file (at devtools/server/actors/object/long-string.js).
But we already have a newer, protocol.js based longString actor: https://searchfox.org/mozilla-central/rev/f5fb323246bf22a3a3b4185882a1c5d8a2c02996/devtools/server/actors/string.js 

We should delete devtools/server/actors/object/long-string.js and use the newest longString actor from actors/string.js

Comment 1

[Manish [:manishkk]]

Here I need to replace all paths of 'long-string.js' with new path of 'string.js' in these files?
https://dxr.mozilla.org/mozilla-central/search?q=long-string.js&redirect=false

or any thing else?

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #0)
> In Bug 1449188, we plan to move the longString actor used by the object
> actor in its own file (at devtools/server/actors/object/long-string.js).
> But we already have a newer, protocol.js based longString actor:
> https://searchfox.org/mozilla-central/rev/
> f5fb323246bf22a3a3b4185882a1c5d8a2c02996/devtools/server/actors/string.js 
> 
> We should delete devtools/server/actors/object/long-string.js and use the
> newest longString actor from actors/string.js

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1449162 will make use of the protocol.js based string actor for network events.  After that lands, there will still be some usages left for other non-network console code paths.

It might be easiest to first wait for that work to land, as it provides an example of what the conversion here might look like.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Manish Kumar from comment #1)
> Here I need to replace all paths of 'long-string.js' with new path of
> 'string.js' in these files?
> https://dxr.mozilla.org/mozilla-central/search?q=long-string.
> js&redirect=false
> 
> or any thing else?
> 

It's a bit more complex I think. We need to make sure that the lngString actor is created as it should, and see if we need to change any client call.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1450977 - Remove old LongStringActor. r=ochameau.

A test is removed as well as it tested this specific actor,
and we have tests for the new LongStringActor.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7999647b29ef
Remove old LongStringActor. r=ochameau.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7999647b29ef