1451014 - Remove iterator to list toolboxes on gDevTools

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Bug 1394750 will introduce and explicit (and easy to search for...) getToolboxes() API on framework/devtools.js

We could try to remove the existing iterator available on gDevTools. A quick search seems to indicate only one call site but there might be surprises. 

https://searchfox.org/mozilla-central/search?q=of+gDevTools)&case=false&regexp=false&path=

Comment 1

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=327b3279ebdc6e7ee0fcd366414e986b661ef4aa

Reasons motivating the removal: I think the current API to list toolboxes is not explicit, which makes it hard to find existing call sites.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1451014 - Remove iterator to list toolboxes on gDevTools;

Review commit: https://reviewboard.mozilla.org/r/234502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234502/

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8965637 [details]
Bug 1451014 - Remove iterator to list toolboxes on gDevTools;

https://reviewboard.mozilla.org/r/234502/#review240598

Sure. I think it was used by xul addons, so we kept it.

You may also want to remove this occurence here:
https://searchfox.org/mozilla-central/source/devtools/client/framework/gDevTools.jsm#96

This module was also here for xul addons.
I removed all usages of it from mozilla-central at some point (bug 1245462),
but some new ones were introduces and should be refactored to use Loader.jsm instead.
https://searchfox.org/mozilla-central/search?q=gDevTools.jsm&case=false&regexp=false&path=
Then, we can remove gDevTools.jsm completely.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8965637 [details]
Bug 1451014 - Remove iterator to list toolboxes on gDevTools;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234502/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the review! Addressed the comment, landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b113a2f83d32
Remove iterator to list toolboxes on gDevTools;r=ochameau

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b113a2f83d32