Closed Bug 1451014 Opened 2 years ago Closed 2 years ago

Remove iterator to list toolboxes on gDevTools

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Bug 1394750 will introduce and explicit (and easy to search for...) getToolboxes() API on framework/devtools.js

We could try to remove the existing iterator available on gDevTools. A quick search seems to indicate only one call site but there might be surprises. 

https://searchfox.org/mozilla-central/search?q=of+gDevTools)&case=false&regexp=false&path=
Summary: Remove iterator on gDevTools → Remove iterator to list toolboxes on gDevTools
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=327b3279ebdc6e7ee0fcd366414e986b661ef4aa

Reasons motivating the removal: I think the current API to list toolboxes is not explicit, which makes it hard to find existing call sites.
Comment on attachment 8965637 [details]
Bug 1451014 - Remove iterator to list toolboxes on gDevTools;

https://reviewboard.mozilla.org/r/234502/#review240598

Sure. I think it was used by xul addons, so we kept it.

You may also want to remove this occurence here:
https://searchfox.org/mozilla-central/source/devtools/client/framework/gDevTools.jsm#96

This module was also here for xul addons.
I removed all usages of it from mozilla-central at some point (bug 1245462),
but some new ones were introduces and should be refactored to use Loader.jsm instead.
https://searchfox.org/mozilla-central/search?q=gDevTools.jsm&case=false&regexp=false&path=
Then, we can remove gDevTools.jsm completely.
Attachment #8965637 - Flags: review?(poirot.alex) → review+
Thanks for the review! Addressed the comment, landing.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b113a2f83d32
Remove iterator to list toolboxes on gDevTools;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/b113a2f83d32
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.