1451115 - UpdateZoomUI throws unnecessary exception if window.gBrowser is not set

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Brad Werth [:bradwerth]]

Sometimes devtools tests are failing with callstacks that indicate an exception being thrown in UpdateZoomUI(). One example:

https://treeherder.mozilla.org/logviewer.html#?job_id=168039651&repo=mozilla-inbound&lineNumber=9603

Based on the function logic, this exception can be avoided. If thrown, the exception tends to mask root causes. In order to generate better callstacks in such cases, the logic should be reworked to remove the possibility of throwing an exception.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1451115 Part 1: Make UpdateZoomUI not throw an exception if gBrowser is not set on window.

Review commit: https://reviewboard.mozilla.org/r/233380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233380/

Comment 2

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f8557c62518390f08446307d520731e9895784f

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1451115 Part 2: Update ZoomManager.getZoomForBrowser() to survive being passed a browser without a zoom level set.

Review commit: https://reviewboard.mozilla.org/r/233386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233386/

Comment 4

[Brad Werth [:bradwerth]]

Comment on attachment 8964688 [details]
Bug 1451115 Part 1: Make UpdateZoomUI not throw an exception if gBrowser is not set on window.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233380/diff/1-2/

Comment 5

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17483aa36672ec0f35fe9bd14ec3767cdcd2c726

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8964688 [details]
Bug 1451115 Part 1: Make UpdateZoomUI not throw an exception if gBrowser is not set on window.

https://reviewboard.mozilla.org/r/233380/#review238976

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8964692 [details]
Bug 1451115 Part 2: Update ZoomManager.getZoomForBrowser() to survive being passed a browser without a zoom level set.

https://reviewboard.mozilla.org/r/233386/#review238978

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad673f1dd375
Part 1: Make UpdateZoomUI not throw an exception if gBrowser is not set on window. r=mossop
https://hg.mozilla.org/integration/autoland/rev/6ca7168ee904
Part 2: Update ZoomManager.getZoomForBrowser() to survive being passed a browser without a zoom level set. r=mossop

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ad673f1dd375
https://hg.mozilla.org/mozilla-central/rev/6ca7168ee904