1451122 - Uninstall extension does not work when system addons are added at the beginning of the list

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:
Screen capture- https://testing-1.tinytake.com/sf/MjQ5MTY4NF83NTAxNDEy

1. Install extensions using this:
{
  "policies": {
    "Extensions": {
      "Install": [
        "https://addons.mozilla.org/firefox/downloads/file/895309/ublock_origin-1.15.18-an+fx.xpi",
        "https://addons.mozilla.org/firefox/downloads/file/808841/adblock_plus-3.0.2-an+fx.xpi"
      ]
    }
  }
}

2. Uninstall addons using this( Note: it has system add-ons at the beginning of the list):
{
  "policies": {
    "Extensions": {
      "Uninstall": [
        "[e-mail]",
        "[e-mail]",
        "{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}",
        "[e-mail]"
      ]
    }
  }
}

3. Check if the two extensions are uninstalled

Actual Result:
The extensions are not removed by the uninstall policy if the list contains non-removable addons (system add-ons) at the beginning of the list.
It works if the list gets reversed.

Expected result:
It should go through all the list of extensions and remove what it should.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

I imagine what's happening is that addon.uninstall() is throwing an error, so the list doesn't continue

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1451122 - Catch errors on uninstallable add-ons.

Review commit: https://reviewboard.mozilla.org/r/233414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233414/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964702 [details]
Bug 1451122 - Catch errors on uninstallable add-ons.

https://reviewboard.mozilla.org/r/233414/#review238986

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d88676178e3e
Catch errors on uninstallable add-ons. r=Felipe

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d88676178e3e

Comment 6

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
Enterprise Policies

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964702 [details]
Bug 1451122 - Catch errors on uninstallable add-ons.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise Policies
[User impact if declined]: kinda of a corner case, but if someone tries to uninstall a non-uninstallable extension, the function will throw instead of continuing to the next addon on the list
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: QA has tested it
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just adds a try-catch around addon.uninstall()
[String changes made/needed]:

Comment 8

[Abe - QA (:Abe_LV)]

We tested this on the latest nightly and it is verified as fixed.
Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8964702 [details]
Bug 1451122 - Catch errors on uninstallable add-ons.

followup fix for enterprise policy, approved for 60.0b11

Comment 10

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5eadcc787606ed668f7a1b81ec1a82cbb9089d94